[ 
https://issues.apache.org/jira/browse/BEAM-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Halperin updated BEAM-697:
---------------------------------
    Summary: TextIO withHeader() and withFooter() overwrite validation setting 
to false  (was: TextIO.Write.Bound.withHeader() and withFooter() do not use the 
current value of validate for the returned Bound instance)

> TextIO withHeader() and withFooter() overwrite validation setting to false
> --------------------------------------------------------------------------
>
>                 Key: BEAM-697
>                 URL: https://issues.apache.org/jira/browse/BEAM-697
>             Project: Beam
>          Issue Type: Bug
>          Components: beam-model
>    Affects Versions: 0.2.0-incubating, 0.3.0-incubating
>            Reporter: Jeffrey Payne
>            Assignee: Jeffrey Payne
>            Priority: Minor
>             Fix For: 0.3.0-incubating
>
>
> {{TextIO.Write.Bound.withHeader()}} and {{TextIO.Write.Bound.withFooter()}} 
> both pass a literal value of {{false}} to the constructor's {{validate}} 
> parameter for the returned {{Bound}} instance.  This could, obviously, lead 
> to unintended behavior wrt pipeline validation.  Looks like a simple copy and 
> paste error from {{TextIO.Write.Bound.withoutValidation()}} :)
> I'm about to push another iteration for a PR for BEAM-55 and have included 
> the *trivial* fix for this bug it in that set of changes.  Creating this in 
> case my PR is not accepted right away.  Please close if this issue is wholly 
> unnecessary.  Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to