[ 
https://issues.apache.org/jira/browse/BEAM-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587808#comment-15587808
 ] 

ASF GitHub Bot commented on BEAM-743:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1084


> JdbcIO should not use getConnection() with username and password when using 
> DBCP BasicDataSource
> ------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-743
>                 URL: https://issues.apache.org/jira/browse/BEAM-743
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>
> When we use an username and password, {{JdbcIO}} uses 
> {{dataSource.getConnection(username, password)}}.
> However, this method is not supported by DBCP {{BasicDataSource}} (as the 
> username and password are already part of the data source).
> Basically, the test should be if username is not null and if datasource (user 
> provided) is not null, then we use {{getConnection(username, password)}} 
> else, we just use {{getConnection()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to