[ 
https://issues.apache.org/jira/browse/BEAM-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596353#comment-15596353
 ] 

ASF GitHub Bot commented on BEAM-498:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1157

    [BEAM-498] Port direct runner to use new DoFn directly

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @tgroh @bjchambers 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam direct-use-new-DoFn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1157
    
----
commit 5541c5115d009083a5826e554c899e8ece3f2433
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T18:23:34Z

    Port ReifyTimestampsAndWindowsDoFn to new DoFn

commit 3191b7dac069ada3a93707323418e8f774cca072
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T18:30:33Z

    Fix NPE in SimpleDoFnRunner

commit 6fb78470c17d6b509800283a47695fc130c4bc6f
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T18:45:38Z

    Move shared DelegatingAggregator out of OldDoFn

commit 2ad63b90ef96e71fa113e4aeb3b2bce1683b0ed6
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T18:49:07Z

    Move AggregatorFactory to runners-core and deprecate SDK version

commit e0f2f5cc9dccd53b48cb3cb13e9d4b91e04dec44
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T18:53:29Z

    Add setupDelegatingAggregators for DoFn (for now)

commit 94254922dfa00c21b9b27d7a069b0dd734b31130
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T03:55:00Z

    Port direct runner to use new DoFn directly

commit 447cc4af495fa6d7cbb39fcd98815d3240d75fa7
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T19:35:03Z

    Port some of ParDoTest to new DoFn

commit 4201bf19ebba25d0becff1b1369d06bd59df85c4
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T19:44:30Z

    Fix binding of aggregator creating in OldDoFn

commit e0fc3bf8686c5af4a0af767b9edb23f2810840e5
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T19:44:47Z

    Fix binding of aggregator delegation in DoFnAdapters

commit dbc50f6a9012462afe8baaed79fb45f54068289e
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T20:35:29Z

    Make DoFnTester aggregator initialization idempotent

commit e43bf14d5943f078182fc0f5b3f322ae7621a752
Author: Kenneth Knowles <[email protected]>
Date:   2016-10-21T20:53:53Z

    Fix flipped conditional in SimpleDoFnRunner

----


> Make DoFnWithContext the new DoFn
> ---------------------------------
>
>                 Key: BEAM-498
>                 URL: https://issues.apache.org/jira/browse/BEAM-498
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>              Labels: backward-incompatible
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to