[
https://issues.apache.org/jira/browse/BEAM-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15598477#comment-15598477
]
ASF GitHub Bot commented on BEAM-239:
-------------------------------------
GitHub user nssalian opened a pull request:
https://github.com/apache/incubator-beam/pull/1164
[BEAM-239]: Rename RemoveDuplicates to Distinct
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Done in the PR:
Refactored the project to replace RemoveDuplicates to Distinct
- [ ] Ran Travis Locally and mvn clean install with SUCCESS to verify
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Requesting review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/incubator-beam BEAM-239
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1164.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1164
----
commit 21e9a6220d7b01fb7adf7b68a45e1f904dd02d5a
Author: Neelesh Srinivas Salian <[email protected]>
Date: 2016-10-22T20:05:48Z
BEAM-239: Refactored the project to replace RemoveDuplicates to Distinct
----
> Rename RemoveDuplicates to Distinct
> -----------------------------------
>
> Key: BEAM-239
> URL: https://issues.apache.org/jira/browse/BEAM-239
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Jesse Anderson
> Assignee: Neelesh Srinivas Salian
> Priority: Minor
> Labels: backward-incompatible, newbie, starter
>
> I had a really tough time finding this transform in the docs. I suggest
> changing this class' name to Distinct instead of RemoveDuplicates. At the
> very least, the JavaDoc for RemoveDuplicates should have the word distinct in
> it to make this more findable/searchable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
