[
https://issues.apache.org/jira/browse/BEAM-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605827#comment-15605827
]
Neelesh Srinivas Salian commented on BEAM-410:
----------------------------------------------
I can take care of both. Thanks [~swegner] for the clarification.
Thanks [~jason.white]
> ApproximateQuantiles$QuantileBuffer defines compareTo but not equals
> --------------------------------------------------------------------
>
> Key: BEAM-410
> URL: https://issues.apache.org/jira/browse/BEAM-410
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Neelesh Srinivas Salian
> Priority: Minor
> Labels: findbugs, newbie, starter
>
> [FindBugs
> EQ_COMPARETO_USE_OBJECT_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L280]:
> Class defines compareTo(...) and uses Object.equals()
> Applies to:
> [ApproximateQuanitles$QuantileBuffer|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L627].
> This is a good starter bug. When fixing, please remove the corresponding
> entries from
> [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml]
> and verify the build passes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
