[
https://issues.apache.org/jira/browse/BEAM-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606442#comment-15606442
]
ASF GitHub Bot commented on BEAM-447:
-------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1188
[BEAM-447] Remove Window.Unbound
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Window PTransforms always have a bound output type; equal to that of the
input PCollection type.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam remove_unbound_visibility
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1188
----
commit ff309805b32bbf893751d0447ed97c78fa54dca9
Author: Thomas Groh <[email protected]>
Date: 2016-07-13T16:59:35Z
Remove Window.Unbound
Window PTransforms always have a bound output type; equal to that of the
input PCollection type.
----
> Stop referring to types with Bound/Unbound
> ------------------------------------------
>
> Key: BEAM-447
> URL: https://issues.apache.org/jira/browse/BEAM-447
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Davor Bonaci
> Labels: backward-incompatible
>
> Bounded and Unbounded are used to refer to PCollections, and the overlap is
> confusing. These classes should be renamed to be both more specific (e.g.
> ParDo.LackingDoFnSingleOutput, ParDo.SingleOutput, Window.AssignWindows)
> which remove the overlap.
> examples:
> https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java#L658
> https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java#L868
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
