GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1190
[BEAM-826] Generate PubSub Subscriptions during Pipeline Execution
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Instead of generating a random subscription at apply-time, create one
as required.
If splitIntoBundles is exercised, generate a subscription if there is
none specified, and create a new PubSub source that uses that
subscription. This is otherwise identical to the current behavior.
If splitIntoBundles is not exercised, and createReader is called with no
checkpoint, create a random subscription. Store a reference to this
subscription is the PubSub checkpoint, including when materialized.
This changes the wire format of PubSub checkpoints, and
as such this change is not update-compatible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam
pubsub_generate_subscription_execution
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1190
----
commit f000e02d67f1fb4dfaac6ae4af55f82e60bd6e2f
Author: Thomas Groh <[email protected]>
Date: 2016-10-25T21:51:08Z
Generate PubSub Subscriptions during Pipeline Execution
Instead of generating a random subscription at apply-time, create one
as required.
If splitIntoBundles is exercised, generate a subscription if there is
none specified, and create a new PubSub source that uses that
subscription. This is otherwise identical to the current behavior.
If splitIntoBundles is not exercised, and createReader is called with no
checkpoint, create a random subscription. Store a reference to this
subscription is the PubSub checkpoint, including when materialized.
This changes the wire format of PubSub checkpoints, and
as such this change is not update-compatible.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
