GitHub user mizitch opened a pull request:
https://github.com/apache/incubator-beam/pull/1221
[BEAM-860] Move Apache RAT license check out of release profile
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Move Apache RAT license check out of release profile. It runs quickly, so
can run as a part of normal mvn verify phase. Will make it so missing licenses
are caught locally more easily.
Tested this locally by removing the license from a file and running 'mvn
clean verify' as well as 'mvn clean verify -P release'. Now both fail, whereas
previously, only 'mvn clean verify -P release' failed.
See discussion at
https://github.com/apache/incubator-beam/pull/1199#issuecomment-256802048
Would you mind looking @dhalperi ? Sorry to send 100% of my two PRs so far
to you, but you do have context on this one...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mizitch/incubator-beam apache-rat-shift
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1221
----
commit b6ede84385357da77d2dc3c7b4f04c654ea79b17
Author: Mitch Shanklin <[email protected]>
Date: 2016-10-28T19:20:55Z
Move Apache RAT license check out of release profile. It runs quickly, so
can run as a part of normal mvn verify phase. Will make it so missing licenses
are caught locally more easily.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
