[
https://issues.apache.org/jira/browse/BEAM-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626783#comment-15626783
]
ASF GitHub Bot commented on BEAM-788:
-------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1251
[BEAM-788] Implement GroupAlsoByWindowsEvaluator Directly
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Invoke the ReduceFnRunner methods directly rather than by constructing a
GroupAlsoByWindowDoFn and a ParDoEvaluator. Instead, construct a
ReduceFnRunner, ReduceFn, and invoke the methods directly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam gabw_implemented_directly
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1251.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1251
----
commit 1cd3dbc5fd35748751c27e17def6100d591ff043
Author: Thomas Groh <tg...@google.com>
Date: 2016-11-01T21:29:48Z
Implement GroupAlsoByWindowsEvaluator Directly
Invoke the ReduceFnRunner methods directly rather than by constructing a
GroupAlsoByWindowDoFn and a ParDoEvaluator. Instead, construct a
ReduceFnRunner, ReduceFn, and invoke the methods directly.
----
> Execute ReduceFn directly, not via OldDoFn wrapper
> --------------------------------------------------
>
> Key: BEAM-788
> URL: https://issues.apache.org/jira/browse/BEAM-788
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Minor
>
> Right now, a ReduceFn is executed as an OldDoFn, depending on deprecated
> methods. We can execute it directly to allow removal of OldDoFn.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
