GitHub user dkulp opened a pull request:
https://github.com/apache/incubator-beam/pull/1265
[BEAM-822] Move the separate package-info.java compile to java7 profile
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Move the separate package-info.java compile to java7 profile since it's not
needed with java8
This fixes compiling in Eclipse (assuming Neon which require java8)
Slightly speeds up Java8 compile (one invoke of compiler plugin)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkulp/incubator-beam eclipse-packageinfo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1265.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1265
----
commit f6efec86fa6301c166a25316490e65900e46fc3c
Author: Daniel Kulp <[email protected]>
Date: 2016-11-02T20:14:00Z
Move the separate package-info.java compile to java7 profile since it's not
needed with java8
This fixes compiling in Eclipse (assuming Neon which require java8)
Slightly speeds up Java8 compile (one invoke of compiler plugin)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
