[
https://issues.apache.org/jira/browse/BEAM-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647990#comment-15647990
]
ASF GitHub Bot commented on BEAM-937:
-------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1313
[BEAM-937][BEAM-938] Update Watermarks even if a Reader is empty
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This ensures that the pipeline will make progress even if a reader stops
producing elements.
Fixes the test bug introduced in #1300 and reverts the rollback of #1303
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam revert_empty_reader_wms
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1313
----
commit 907aae24f5b0f59420b6ba421380accdb9ac7cb7
Author: Thomas Groh <[email protected]>
Date: 2016-11-07T20:59:06Z
Update Watermarks even if a Reader is empty
This ensures that the pipeline will make progress even if a reader stops
producing elements.
----
> The DirectRunner does not advance watermarks if reading from an empty reader
> ----------------------------------------------------------------------------
>
> Key: BEAM-937
> URL: https://issues.apache.org/jira/browse/BEAM-937
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
