[
https://issues.apache.org/jira/browse/BEAM-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649037#comment-15649037
]
ASF GitHub Bot commented on BEAM-897:
-------------------------------------
GitHub user vikkyrk opened a pull request:
https://github.com/apache/incubator-beam/pull/1317
[BEAM-897] Fix DatastoreIT PipelineOptions
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
- Remove projectId from V1TestOptions and use the one from GcpOptions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vikkyrk/incubator-beam ds_it
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1317.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1317
----
commit c2093c88bc18b03378c96605a298b0a1606f13d0
Author: Vikas Kedigehalli <[email protected]>
Date: 2016-11-08T22:41:25Z
Fix DatastoreIT test options
----
> Datastore ITs have invalid PipelineOptions
> ------------------------------------------
>
> Key: BEAM-897
> URL: https://issues.apache.org/jira/browse/BEAM-897
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-gcp, testing
> Reporter: Daniel Halperin
> Assignee: Vikas Kedigehalli
>
> https://builds.apache.org/job/beam_PostCommit_MavenVerify/1718/
> This PR: https://github.com/apache/incubator-beam/pull/1159
> checks that pipeline options cannot have multiple incompatible defaults.
> Datastore ITs currently do have multiple incompatible defaults, and this
> should be rectified.
> cc [[email protected]] [~lcwik]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
