[
https://issues.apache.org/jira/browse/BEAM-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649052#comment-15649052
]
ASF GitHub Bot commented on BEAM-922:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1318
[BEAM-922] Fix findbugs errors and re-enable for runners-core
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @dhalperi
The error in `UnboundedReadFromBoundedSource` was a real coding error;
please review my small edit there.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam
runners-core-findbugs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1318
----
commit 2a4f6fffcdcf1804b1c173d6e4ab43ffc0431cb7
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-08T22:49:09Z
Fix findbugs errors and re-enable for runners-core
----
> runner-core does not pass under findbugs
> ----------------------------------------
>
> Key: BEAM-922
> URL: https://issues.apache.org/jira/browse/BEAM-922
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Daniel Halperin
> Assignee: Kenneth Knowles
>
> @Kenn because mostly in state machines. Since Findbugs doesn't grok
> reflection, probably just need suppressions.
> {code}
> INFO] Dead store to invoker rather than field with same name in new
> org.apache.beam.runners.core.SplittableParDo$ProcessFn(DoFn, Coder, Coder,
> Coder) [org.apache.beam.runners.core.SplittableParDo$ProcessFn] At
> SplittableParDo.java:[line 242]
> [INFO] Possible null pointer dereference of
> UnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource.reader
> in
> org.apache.beam.runners.core.UnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource.advance()
>
> [org.apache.beam.runners.core.UnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource,
>
> org.apache.beam.runners.core.UnboundedReadFromBoundedSource$BoundedToUnboundedSourceAdapter$ResidualSource]
> Dereferenced at UnboundedReadFromBoundedSource.java:[line 476]Known null at
> UnboundedReadFromBoundedSource.java:[line 472]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(AfterAll)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[lines 130-135]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(AfterEach)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[lines 154-161]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(AfterFirst)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[lines 121-126]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(AfterPane)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[line 139]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(AfterProcessingTime)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[line 175]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(AfterSynchronizedProcessingTime)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[line 117]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(AfterWatermark$AfterWatermarkEarlyAndLate)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[lines 144-150]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(AfterWatermark$FromEndOfWindow)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[line 109]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(DefaultTrigger)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[line 101]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(Never$NeverTrigger)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[line 113]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(OrFinallyTrigger)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[lines 169-171]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(Repeatedly)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[line 165]
> [INFO] Private method
> org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter.evaluateSpecific(ReshuffleTrigger)
> is never called
> [org.apache.beam.runners.core.triggers.TriggerStateMachines$StateMachineConverter]
> At TriggerStateMachines.java:[line 105]
> [INFO]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
