[
https://issues.apache.org/jira/browse/BEAM-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652588#comment-15652588
]
ASF GitHub Bot commented on BEAM-951:
-------------------------------------
GitHub user peihe opened a pull request:
https://github.com/apache/incubator-beam/pull/1329
[BEAM-951] FileBasedSink: merge FileOperations into IOChannelFactory.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peihe/incubator-beam rm-file-operations
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1329
----
commit 53fb4dbd8b102a807e4a70bb0c13d7a2496fbf22
Author: Pei He <[email protected]>
Date: 2016-11-10T01:09:13Z
[BEAM-951] FileBasedSink: merge FileOperations into IOChannelFactory.
----
> Cleanup FileBasedSink to prepare IOChannelFactory redesign.
> -----------------------------------------------------------
>
> Key: BEAM-951
> URL: https://issues.apache.org/jira/browse/BEAM-951
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core, sdk-java-gcp
> Reporter: Pei He
> Assignee: Pei He
>
> FileBasedSink uses both FileOperations and IOChannelFactory interfaces, and
> they need to be merged.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
