GitHub user chamikaramj opened a pull request:
https://github.com/apache/incubator-beam/pull/1385
Fixes couple of issues of FileBasedSource.
(1) Updates code so that a user-specified coder properly gets set to splits.
(2) Currently each SingleFileSource takes a reference to FileBasedSource
while FileBasedSource takes a reference to Concatsource. ConcatSource has a
reference to list of SingleFileSources. This results in quadratic space
complexity when serializing splits of a FileBasedSource. This CL fixes this by
making sure that FileBasedSource is cloned before taking a reference to
ConcatSource
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chamikaramj/incubator-beam
filebasedsource_manyfiles_fix1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1385.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1385
----
commit 0851a8fc2cf6214673777e31bdacaa3409547a6c
Author: Chamikara Jayalath <[email protected]>
Date: 2016-11-18T03:18:26Z
Fixes a couple of issues of FileBasedSource.
(1) Updates code so that a user-specified coder properly gets set to
sub-sources.
(2) Currently each SingleFileSource takes a reference to FileBasedSource
while FileBasedSource takes a reference to Concatsource. ConcatSource has a
reference to list of SingleFileSources. This results in quadratic space
complexity when serializing splits of a FileBasedSource. This CL fixes this
issue by making sure that FileBasedSource is cloned before taking a reference
to ConcatSource
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
