[ https://issues.apache.org/jira/browse/BEAM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15678335#comment-15678335 ]
ASF GitHub Bot commented on BEAM-1010: -------------------------------------- GitHub user katsiapis opened a pull request: https://github.com/apache/incubator-beam/pull/1391 [BEAM-1010] A few improvements to Apache Beam Python's FileIO. - Ensuring that AUTO compression works properly for FileSinks. - Introducing __enter__ and __exit__ in _CompressedFile to allow use of "with", and updating textio accordingly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/katsiapis/incubator-beam fileio Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1391.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1391 ---- commit aa8b2020e8cad004189373d7aca195c088d96040 Author: Gus Katsiapis <katsia...@katsiapis-linux.mtv.corp.google.com> Date: 2016-11-19T01:16:47Z A few improvements to Apache Beam Python's FileIO. - Ensuring that AUTO compression works properly for FileSinks. - Introducing __enter__ and __exit__ in _CompressedFile to allow use of "with", and updating textio accordingly. ---- > Custom FileSinks should respect AUTO compression > ------------------------------------------------ > > Key: BEAM-1010 > URL: https://issues.apache.org/jira/browse/BEAM-1010 > Project: Beam > Issue Type: Bug > Reporter: Konstantinos Katsiapis > Assignee: Konstantinos Katsiapis > > Currently AUTO compression is respected by Native FileSinks but not Custom > FileSinks. > Also, it would be good for Beam's _CompresedFile to support usage with Python > "with" clause (ie implement __enter__ and __exit__). -- This message was sent by Atlassian JIRA (v6.3.4#6332)