[
https://issues.apache.org/jira/browse/BEAM-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685770#comment-15685770
]
ASF GitHub Bot commented on BEAM-25:
------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1408
[BEAM-25] Temporarily reject stateful ParDo in FlinkRunner (until support
is added)
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @aljoscha or @mxm
At present, the user-facing API for stateful `DoFn` is in the codebase but
prevented from use. It is `ParDo.of(...)` that rejects stateful `DoFn`. In
#1399 I am removing this rejection, so I need to add it to all runners until
they support the API.
I have also added a JUnit category so runners can exclude this from their
`RunnableOnService` test suites.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam FlinkRunner-state
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1408.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1408
----
commit 7de2ea30c46d076771d2759111558a01d39d8a84
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-16T05:33:28Z
Reject stateful DoFn in FlinkRunner
commit 75744f99d5ef0cb7c0da333c2f0651ee13901e8f
Author: Kenneth Knowles <[email protected]>
Date: 2016-11-21T23:41:13Z
Add JUnit category for stateful ParDo tests
----
> Add user-ready API for interacting with state
> ---------------------------------------------
>
> Key: BEAM-25
> URL: https://issues.apache.org/jira/browse/BEAM-25
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Labels: State
>
> Our current state API is targeted at runner implementers, not pipeline
> authors. As such it has many capabilities that are not necessary nor
> desirable for simple use cases of stateful ParDo (such as dynamic state tag
> creation). Implement a simple state intended for user access.
> (Details of our current thoughts in forthcoming design doc)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
