[
https://issues.apache.org/jira/browse/BEAM-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702717#comment-15702717
]
ASF GitHub Bot commented on BEAM-230:
-------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1440
[BEAM-230] Remove WindowedValue.valueInEmptyWindows
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
A value in empty windows expands to no values, so it can be dropped at any
time, perhaps unintentionally. This has affected real runners.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam valueInEmptyWindows
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1440
----
commit 05fb97b7133d79f343d0d6d6b26a3a56f8ee848b
Author: Kenneth Knowles <k...@google.com>
Date: 2016-05-10T18:39:35Z
Remove WindowedValue.valueInEmptyWindows
A value in empty windows expands to no values, so it can be dropped at
any time, perhaps unintentionally. This has bitten runner authors, including
Spark & Dataflow.
While creating such a thing in memory is not automatically problematic, it
is also not really useful. So this change removes it.
----
> Remove WindowedValue#valueInEmptyWindows
> ----------------------------------------
>
> Key: BEAM-230
> URL: https://issues.apache.org/jira/browse/BEAM-230
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Kenneth Knowles
> Labels: backward-incompatible
> Fix For: Not applicable
>
>
> A WindowedValue in no windows does not exist, and can be dropped by a runner
> at any time.
> We should also assert that any collection of windows is nonempty when
> creating a new WindowedValue. If a user wants to drop an element, they should
> explicitly filter it out rather than expecting it to be dropped by the runner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
