[
https://issues.apache.org/jira/browse/BEAM-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725282#comment-15725282
]
ASF GitHub Bot commented on BEAM-651:
-------------------------------------
GitHub user nssalian opened a pull request:
https://github.com/apache/incubator-beam/pull/1516
[BEAM-651]: Consider making TypedPValue.setTypeDescriptorInternal no longer
Internal
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
If this contribution is large, please file an Apache
Individual Contributor License Agreement.
On the PR: Refactored the project to modify the name of
setTypeDescriptorInternal to setTypeDescriptor.
Ran a mvn clean install to SUCCESS and a local TRAVIS build went through as
well.
R: @kennknowles
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/incubator-beam BEAM-651
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1516.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1516
----
commit 922ca31f560621d55861b1bc4af9ded7ba2e6f62
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-12-06T11:58:01Z
BEAM-651: Changed setTypeDescriptorInternal to setTypeDescriptor in the
project
----
> Consider making TypedPValue.setTypeDescriptorInternal no longer Internal
> ------------------------------------------------------------------------
>
> Key: BEAM-651
> URL: https://issues.apache.org/jira/browse/BEAM-651
> Project: Beam
> Issue Type: Wish
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Neelesh Srinivas Salian
> Priority: Minor
> Labels: easy, easyfix, starter
>
> This would give fairly pithy answers to StackOverflow questions sometimes.
> When choosing between .getOutputCoder() and .getOutputTypeDescriptor() for a
> transform/DoFn we often choose the type, so the coder registry can do its
> thing.
> This would also give a similar choice between .setCoder(...) and
> .setTypeDescriptor(...).
> And anyhow we have the intention of removing our practice of the "*Internal"
> suffix, so this one might be most easily solved by making it public.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
