[
https://issues.apache.org/jira/browse/BEAM-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731074#comment-15731074
]
ASF GitHub Bot commented on BEAM-27:
------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1550
[BEAM-27] Reject timers for ParDo in each runner separately and exclude
timer tests
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
There are many trivial commits spread across the runners, in two phases.
1. Add a JUnit category for timers and exclude it from all runners. I've
included one trivial test just to see that it is working. (FWIW I have hacked
the direct runner enough in later commits to get this test to pass "for the
wrong reasons")
2. Remove the timer rejection code from `ParDo` and add it to every runner.
R: @tgroh @aljoscha @amitsela @tweise
I'll wait for all four to LGTM.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam UsesTimers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1550.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1550
----
commit 5c99d2c3a573c3963fd6efa9e11ed860d26f0365
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-07T04:49:15Z
Add JUnit category UsesTimersInParDo
With this, various runners can disable tests for this capability
until they support it.
commit 604695f1b7cbd6dfeda94d82532fde535b3e3448
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-07T04:52:24Z
Disable tests for timers in ParDo for Apex runner
commit cccc58cac2f4960044e646249eb8a3db27b345e1
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-07T04:52:49Z
Disable tests for timers in ParDo for Flink runner
commit f27bdf9b3c2e609c54615db60f0682b34f6575c5
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-07T04:53:05Z
Disables tests for timers in ParDo for Spark runner
commit be9c04bf0f2af7b428a61d3b74b68ea18c4f0e03
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-07T04:53:16Z
Disable tests for timers in ParDo for Dataflow runner
commit b66c5cb4f92e2c0d834f44ba246b8186cc9d0291
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-08T04:24:34Z
Disable tests for timers in ParDo for direct runner
commit e4f062495878328359234da4e586d12cb42965f9
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-07T04:49:40Z
Add basic test for timers in ParDoTest
commit ad4cbbc18ffbbedaaa17415220d7ff2908931797
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-08T04:04:51Z
No longer reject timers in ParDo
commit 0703093767db2776965384b09b322f01f4b79b39
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-08T04:34:34Z
Reject timers for ParDo in ApexRunner
commit 4b312e8d01e324db77e5f2de62eae35efc153adb
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-08T04:34:59Z
Reject timers for ParDo in FlinkRunner
commit 2e2bc885deb5000a269800bdbead8f17dff5a3a9
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-08T04:35:08Z
Reject timers for ParDo in SparkRunner
commit 2d2d83f721c21f681f431974edc4e044d44828c5
Author: Kenneth Knowles <k...@google.com>
Date: 2016-12-08T04:37:33Z
Reject timers for ParDo in DirectRunner
----
> Add user-ready API for interacting with timers
> ----------------------------------------------
>
> Key: BEAM-27
> URL: https://issues.apache.org/jira/browse/BEAM-27
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
> Pipeline authors will benefit from a different factorization of interaction
> with underlying timers. The current APIs are targeted at runner implementers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
