[
https://issues.apache.org/jira/browse/BEAM-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733507#comment-15733507
]
ASF GitHub Bot commented on BEAM-23:
------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1556
[BEAM-23] Refactors to support key-preserving in direct runner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @tgroh
I've peeled these commits off since they make some sense on their own. The
intent is that just tweaking the logic in `KeyedPValueTrackingVisitor` (in
potentially hacky ways :-) we can start to allow key preservation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam
KeyedPValueTrackingVisitor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1556
----
commit d350b3d3708b83508d3e1df56638e0104ec28b83
Author: Kenneth Knowles <[email protected]>
Date: 2016-12-08T19:49:15Z
Add some key-preserving to KeyedPValueTrackingVisitor
commit 93e3af2dba38dea4a708ce4d85d29cf74e029de4
Author: Kenneth Knowles <[email protected]>
Date: 2016-12-08T21:28:44Z
Move responsibility for knowing about keyedness into EvaluationContext
This will allow transform evaluators to inquire about whether
various collections are keyed.
commit 1c756f85c8a04422d28e6063ba4072dd4fb0ea73
Author: Kenneth Knowles <[email protected]>
Date: 2016-12-08T19:44:48Z
Propagate key through ParDo if DoFn is key-preserving
----
> User-facing state and timers for ParDo(DoFn)
> --------------------------------------------
>
> Key: BEAM-23
> URL: https://issues.apache.org/jira/browse/BEAM-23
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Labels: State
> Fix For: Not applicable
>
>
> To a key-partitioned ParDo, add the ability for a user's DoFn to, on a
> per-key-and-window basis:
> - read and write consistent state
> - set a timer to request a callback at a particular moment (in any time
> domain)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
