[
https://issues.apache.org/jira/browse/BEAM-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15743569#comment-15743569
]
ASF GitHub Bot commented on BEAM-1139:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/1586
[BEAM-1139] Add no-arg constructor for UnboundedReadFromBoundedSource
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
This allows Kryo to work with the type, currently required by
the Apex runner.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam take_over_1585
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1586.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1586
----
commit e88e9edfcca65066d3f40d0fa49ba7386e09652f
Author: Kenneth Knowles <[email protected]>
Date: 2016-12-12T22:59:36Z
Add no-arg constructor for UnboundedReadFromBoundedSource
This allows Kryo to work with the type, currently required by
the Apex runner.
----
> Failures in precommit - Apex & Kryo
> -----------------------------------
>
> Key: BEAM-1139
> URL: https://issues.apache.org/jira/browse/BEAM-1139
> Project: Beam
> Issue Type: Improvement
> Components: runner-apex
> Reporter: Kenneth Knowles
> Assignee: Thomas Weise
> Priority: Blocker
>
> https://builds.apache.org/view/Beam/job/beam_PreCommit_Java_MavenInstall/org.apache.beam$beam-examples-java/5775/testReport/junit/org.apache.beam.examples/WordCountIT/testE2EWordCount/
> This is not necessarily a bug in the Apex runner, but it looks like this
> class cannot be serialized via Kryo while the Apex runner needs it to be.
> Probably the fix is to roll-forwards a simple change to make it Kryo
> serializable.
> It is not clear to me the difference between this test run and others.
> Clearly there is a coverage gap.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
