GitHub user bjchambers opened a pull request:
https://github.com/apache/incubator-beam/pull/1625
Don't incorrectly log error in MetricsEnvironment
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [*] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [*] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [*] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
Using getCurrentContainer() logs an error if metrics are not supported.
This is because it acts as the common point of access for user code that
reports metrics.
It should not be used within setCurrentContainer(), because the first
container being set will have a null previous-current-container, which
will cause the error to be incorrectly logged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bjchambers/incubator-beam fix-metrics-warning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1625
----
commit 125223f8feb3576d3ff5ccdffa58a5e80808286c
Author: bchambers <bchamb...@google.com>
Date: 2016-12-14T19:23:39Z
Don't incorrectly log error in MetricsEnvironment
Using getCurrentContainer() logs an error if metrics are not supported.
This is because it acts as the common point of access for user code that
reports metrics.
It should not be used within setCurrentContainer(), because the first
container being set will have a null previous-current-container, which
will cause the error to be incorrectly logged.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
