[ https://issues.apache.org/jira/browse/BEAM-545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756581#comment-15756581 ]
ASF GitHub Bot commented on BEAM-545: ------------------------------------- GitHub user dhalperi opened a pull request: https://github.com/apache/incubator-beam/pull/1653 [BEAM-545] PipelineOptions: fix parameter name Seems like a cut and paste error. R: @peihe You can merge this pull request into a Git repository by running: $ git pull https://github.com/dhalperi/incubator-beam patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1653.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1653 ---- commit 65afadb15cc320acc4e1562aec0de0c82fd102bd Author: Daniel Halperin <dhalp...@users.noreply.github.com> Date: 2016-12-17T07:47:56Z [BEAM-545] PipelineOptions: fix parameter name Seems like a cut and paste error. R: @peihe ---- > Pipelines and their executions naming changes > --------------------------------------------- > > Key: BEAM-545 > URL: https://issues.apache.org/jira/browse/BEAM-545 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core > Reporter: Pei He > Assignee: Pei He > Priority: Minor > Fix For: 0.3.0-incubating > > > The purpose of the changes is to clarify the differences between the two, have > consensus between runners, and unify the implementation. > Current states: > * PipelineOptions.appName defaults to mainClass name > * DataflowPipelineOptions.jobName defaults to appName+user+datetime > * FlinkPipelineOptions.jobName defaults to appName+user+datetime > Proposal: > 1. Replace PipelineOptions.appName with PipelineOptions.pipelineName. > * It is the user-visible name for a specific graph. > * default to mainClass name. > * Use cases: Find all executions of a pipeline > 2. Add jobName to top level PipelineOptions. > * It is the unique name for an execution > * defaults to pipelineName + user + datetime + random Integer > * Use cases: > -- Finding all executions by USER_A between TIME_X and TIME_Y > -- Naming resources created by the execution. for example: -- This message was sent by Atlassian JIRA (v6.3.4#6332)