[ 
https://issues.apache.org/jira/browse/BEAM-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764778#comment-15764778
 ] 

Luke Cwik commented on BEAM-1176:
---------------------------------

I took a look at AvroIOGeneratedClassTest, ApproximateUniqueTest, SampleTest 
and BigtableIOTest. It seemed as though all multi-pipeline cases were just 
different variants of the same pipeline. It seems as though if these tests were 
broken up into multiple tests or better yet a set of paramemterized tests 
(https://github.com/Pragmatists/junitparams), we could use the test rule.

> Make our test suites use @Rule TestPipeline
> -------------------------------------------
>
>                 Key: BEAM-1176
>                 URL: https://issues.apache.org/jira/browse/BEAM-1176
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Stas Levin
>            Priority: Minor
>
> Now that [~staslev] has made {{TestPipeline}} a JUnit rule that performs 
> useful sanity checks, we should port all of our tests to it so that they set 
> a good example for users. Maybe we'll even catch some straggling tests with 
> errors :-)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to