Gujiawei-Edinburgh commented on code in PR #188:
URL: https://github.com/apache/bifromq/pull/188#discussion_r2514252837
##########
base-env/base-env-provider/src/main/java/org/apache/bifromq/baseenv/ZeroCopyParser.java:
##########
@@ -43,4 +44,17 @@ public static <T> T parse(ByteString bytes, Parser<T>
parser) throws InvalidProt
input.enableAliasing(true);
Review Comment:
I am not pretty sure, since from the enableAliasing comments, it says:
"Enables ByteString aliasing of the underlying buffer, trading off on buffer
pinning for data copies. Only valid for buffer-backed streams". So i think the
pinning buffer here means the direct buffer memory will be pinned until the PB
obj is garbage collected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
