This is an automated email from the ASF dual-hosted git repository.
liuhaopeng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/bigtop-manager.git
The following commit(s) were added to refs/heads/main by this push:
new a9657209 BIGTOP-4376: Add ut cases for command stage classes in server
module (#183)
a9657209 is described below
commit a96572096e444a3ca5d60e150e519dc9bac5a777
Author: xianrenzw <[email protected]>
AuthorDate: Sun Feb 23 16:49:59 2025 +0800
BIGTOP-4376: Add ut cases for command stage classes in server module (#183)
---
.../server/command/stage/AbstractStage.java | 5 +
.../server/command/stage/ComponentStageTest.java | 159 +++++++++++++++++++++
.../server/command/stage/HostCheckStageTest.java | 110 ++++++++++++++
.../server/command/stage/SetupJdkStageTest.java | 110 ++++++++++++++
4 files changed, 384 insertions(+)
diff --git
a/bigtop-manager-server/src/main/java/org/apache/bigtop/manager/server/command/stage/AbstractStage.java
b/bigtop-manager-server/src/main/java/org/apache/bigtop/manager/server/command/stage/AbstractStage.java
index 47f99871..15b821cd 100644
---
a/bigtop-manager-server/src/main/java/org/apache/bigtop/manager/server/command/stage/AbstractStage.java
+++
b/bigtop-manager-server/src/main/java/org/apache/bigtop/manager/server/command/stage/AbstractStage.java
@@ -161,4 +161,9 @@ public abstract class AbstractStage implements Stage {
return stagePO;
}
+
+ protected void setStageContextAndTasksForTest(StageContext stageContext,
List<Task> tasks) {
+ this.stageContext = stageContext;
+ this.tasks = tasks;
+ }
}
diff --git
a/bigtop-manager-server/src/test/java/org/apache/bigtop/manager/server/command/stage/ComponentStageTest.java
b/bigtop-manager-server/src/test/java/org/apache/bigtop/manager/server/command/stage/ComponentStageTest.java
new file mode 100644
index 00000000..c8a19bed
--- /dev/null
+++
b/bigtop-manager-server/src/test/java/org/apache/bigtop/manager/server/command/stage/ComponentStageTest.java
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.bigtop.manager.server.command.stage;
+
+import org.apache.bigtop.manager.dao.po.StagePO;
+import org.apache.bigtop.manager.dao.repository.ClusterDao;
+import org.apache.bigtop.manager.dao.repository.HostDao;
+import org.apache.bigtop.manager.dao.repository.StageDao;
+import org.apache.bigtop.manager.server.command.task.Task;
+import org.apache.bigtop.manager.server.holder.SpringContextHolder;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.MockedStatic;
+import org.mockito.Spy;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doCallRealMethod;
+import static org.mockito.Mockito.lenient;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockStatic;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+@ExtendWith(MockitoExtension.class)
+public class ComponentStageTest {
+
+ private MockedStatic<SpringContextHolder> springContextHolderMockedStatic;
+
+ @Mock
+ private StageDao stageDao;
+
+ @Mock
+ private HostDao hostDao;
+
+ @Mock
+ private ClusterDao clusterDao;
+
+ @Spy
+ private StageContext stageContext;
+
+ @Mock
+ private List<Task> tasks;
+
+ @Spy
+ private StagePO stagePO;
+
+ private ComponentAddStage componentStage;
+
+ @BeforeEach
+ public void setUp() {
+ springContextHolderMockedStatic =
mockStatic(SpringContextHolder.class);
+ when(SpringContextHolder.getBean(StageDao.class)).thenReturn(stageDao);
+ when(SpringContextHolder.getBean(HostDao.class)).thenReturn(hostDao);
+
when(SpringContextHolder.getBean(ClusterDao.class)).thenReturn(clusterDao);
+
+ componentStage = mock(ComponentAddStage.class);
+
+ stageContext.setComponentName("TestComponentName");
+ stageContext.setServiceName("TestServiceName");
+ stageContext.setClusterId(123L);
+
+
doCallRealMethod().when(componentStage).setStageContextAndTasksForTest(any(),
any());
+ componentStage.setStageContextAndTasksForTest(stageContext, tasks);
+
+ doCallRealMethod().when(componentStage).injectBeans();
+ componentStage.injectBeans();
+
+ doCallRealMethod().when(componentStage).loadStagePO(any());
+ lenient().when(componentStage.getStagePO()).thenCallRealMethod();
+ componentStage.loadStagePO(stagePO);
+ }
+
+ @AfterEach
+ public void tearDown() {
+ springContextHolderMockedStatic.close();
+ }
+
+ @Test
+ public void testInjectBeans() {
+ springContextHolderMockedStatic.verify(() ->
SpringContextHolder.getBean(any(Class.class)), times(3));
+ }
+
+ @Test
+ public void testBeforeCreateTasks() {
+ doCallRealMethod().when(componentStage).beforeCreateTasks();
+ componentStage.beforeCreateTasks();
+ verify(clusterDao, times(1)).findById(123L);
+ }
+
+ @Test
+ public void tesGetServiceName() {
+ doCallRealMethod().when(componentStage).getServiceName();
+ assertEquals("TestServiceName", componentStage.getServiceName());
+ }
+
+ @Test
+ public void tesGetComponentName() {
+ doCallRealMethod().when(componentStage).getComponentName();
+ assertEquals("TestComponentName", componentStage.getComponentName());
+ }
+
+ @Test
+ public void testBeforeRun() {
+ doCallRealMethod().when(componentStage).beforeRun();
+ componentStage.beforeRun();
+ verify(stageDao, times(1)).partialUpdateById(any());
+ }
+
+ @Test
+ public void testOnSuccess() {
+ doCallRealMethod().when(componentStage).onSuccess();
+ componentStage.onSuccess();
+ verify(stageDao, times(1)).partialUpdateById(any());
+ }
+
+ @Test
+ public void testOnFailure() {
+ doCallRealMethod().when(componentStage).onFailure();
+ componentStage.onFailure();
+ verify(stageDao, times(1)).partialUpdateById(any());
+ }
+
+ @Test
+ public void testGetStageContext() {
+ doCallRealMethod().when(componentStage).getStageContext();
+ assertEquals(stageContext, componentStage.getStageContext());
+ }
+
+ @Test
+ public void testGetTasks() {
+ doCallRealMethod().when(componentStage).getTasks();
+ assertEquals(tasks, componentStage.getTasks());
+ }
+}
diff --git
a/bigtop-manager-server/src/test/java/org/apache/bigtop/manager/server/command/stage/HostCheckStageTest.java
b/bigtop-manager-server/src/test/java/org/apache/bigtop/manager/server/command/stage/HostCheckStageTest.java
new file mode 100644
index 00000000..317ccd82
--- /dev/null
+++
b/bigtop-manager-server/src/test/java/org/apache/bigtop/manager/server/command/stage/HostCheckStageTest.java
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.bigtop.manager.server.command.stage;
+
+import org.apache.bigtop.manager.dao.po.StagePO;
+import org.apache.bigtop.manager.dao.repository.HostDao;
+import org.apache.bigtop.manager.dao.repository.StageDao;
+import org.apache.bigtop.manager.server.command.task.Task;
+import org.apache.bigtop.manager.server.holder.SpringContextHolder;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.MockedStatic;
+import org.mockito.Spy;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doCallRealMethod;
+import static org.mockito.Mockito.lenient;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockStatic;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.when;
+
+@ExtendWith(MockitoExtension.class)
+public class HostCheckStageTest {
+
+ private MockedStatic<SpringContextHolder> springContextHolderMockedStatic;
+
+ @Mock
+ private StageDao stageDao;
+
+ @Mock
+ private HostDao hostDao;
+
+ @Spy
+ private StageContext stageContext;
+
+ @Mock
+ private List<Task> tasks;
+
+ @Spy
+ private StagePO stagePO;
+
+ private HostCheckStage hostCheckStage;
+
+ @BeforeEach
+ public void setUp() {
+ springContextHolderMockedStatic =
mockStatic(SpringContextHolder.class);
+ when(SpringContextHolder.getBean(StageDao.class)).thenReturn(stageDao);
+ when(SpringContextHolder.getBean(HostDao.class)).thenReturn(hostDao);
+
+ hostCheckStage = mock(HostCheckStage.class);
+
+
doCallRealMethod().when(hostCheckStage).setStageContextAndTasksForTest(any(),
any());
+ hostCheckStage.setStageContextAndTasksForTest(stageContext, tasks);
+
+ doCallRealMethod().when(hostCheckStage).injectBeans();
+ hostCheckStage.injectBeans();
+
+ doCallRealMethod().when(hostCheckStage).loadStagePO(any());
+ lenient().when(hostCheckStage.getStagePO()).thenCallRealMethod();
+ hostCheckStage.loadStagePO(stagePO);
+ }
+
+ @AfterEach
+ public void tearDown() {
+ springContextHolderMockedStatic.close();
+ }
+
+ @Test
+ public void testInjectBeans() {
+ springContextHolderMockedStatic.verify(() ->
SpringContextHolder.getBean(any(Class.class)), times(2));
+ }
+
+ @Test
+ public void testBeforeCreateTasks() {
+ doCallRealMethod().when(hostCheckStage).beforeCreateTasks();
+ assertDoesNotThrow(() -> hostCheckStage.beforeCreateTasks());
+ }
+
+ @Test
+ public void tesGetName() {
+ doCallRealMethod().when(hostCheckStage).getName();
+ assertEquals("Check hosts", hostCheckStage.getName());
+ }
+}
diff --git
a/bigtop-manager-server/src/test/java/org/apache/bigtop/manager/server/command/stage/SetupJdkStageTest.java
b/bigtop-manager-server/src/test/java/org/apache/bigtop/manager/server/command/stage/SetupJdkStageTest.java
new file mode 100644
index 00000000..0c18be92
--- /dev/null
+++
b/bigtop-manager-server/src/test/java/org/apache/bigtop/manager/server/command/stage/SetupJdkStageTest.java
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.bigtop.manager.server.command.stage;
+
+import org.apache.bigtop.manager.dao.po.StagePO;
+import org.apache.bigtop.manager.dao.repository.HostDao;
+import org.apache.bigtop.manager.dao.repository.StageDao;
+import org.apache.bigtop.manager.server.command.task.Task;
+import org.apache.bigtop.manager.server.holder.SpringContextHolder;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.MockedStatic;
+import org.mockito.Spy;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doCallRealMethod;
+import static org.mockito.Mockito.lenient;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.mockStatic;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.when;
+
+@ExtendWith(MockitoExtension.class)
+public class SetupJdkStageTest {
+
+ private MockedStatic<SpringContextHolder> springContextHolderMockedStatic;
+
+ @Mock
+ private StageDao stageDao;
+
+ @Mock
+ private HostDao hostDao;
+
+ @Spy
+ private StageContext stageContext;
+
+ @Mock
+ private List<Task> tasks;
+
+ @Spy
+ private StagePO stagePO;
+
+ private SetupJdkStage setupJdkStage;
+
+ @BeforeEach
+ public void setUp() {
+ springContextHolderMockedStatic =
mockStatic(SpringContextHolder.class);
+ when(SpringContextHolder.getBean(StageDao.class)).thenReturn(stageDao);
+ when(SpringContextHolder.getBean(HostDao.class)).thenReturn(hostDao);
+
+ setupJdkStage = mock(SetupJdkStage.class);
+
+
doCallRealMethod().when(setupJdkStage).setStageContextAndTasksForTest(any(),
any());
+ setupJdkStage.setStageContextAndTasksForTest(stageContext, tasks);
+
+ doCallRealMethod().when(setupJdkStage).injectBeans();
+ setupJdkStage.injectBeans();
+
+ doCallRealMethod().when(setupJdkStage).loadStagePO(any());
+ lenient().when(setupJdkStage.getStagePO()).thenCallRealMethod();
+ setupJdkStage.loadStagePO(stagePO);
+ }
+
+ @AfterEach
+ public void tearDown() {
+ springContextHolderMockedStatic.close();
+ }
+
+ @Test
+ public void testInjectBeans() {
+ springContextHolderMockedStatic.verify(() ->
SpringContextHolder.getBean(any(Class.class)), times(2));
+ }
+
+ @Test
+ public void testBeforeCreateTasks() {
+ doCallRealMethod().when(setupJdkStage).beforeCreateTasks();
+ assertDoesNotThrow(() -> setupJdkStage.beforeCreateTasks());
+ }
+
+ @Test
+ public void tesGetName() {
+ doCallRealMethod().when(setupJdkStage).getName();
+ assertEquals("Setup JDK", setupJdkStage.getName());
+ }
+}
