#561: Display more user-friendly error page when navigating to a non-existing
product
---------------------------+-----------------------
Reporter: rjollos | Owner: rjollos
Type: enhancement | Status: closed
Priority: major | Milestone: Release 6
Component: multiproduct | Version:
Resolution: fixed | Keywords: hooks
---------------------------+-----------------------
Changes (by rjollos):
* status: review => closed
* resolution: => fixed
Comment:
(In [1495037])
Fixes #561: Display a warning and the products list when accessing a non-
existent product. Patch from Olemis, with minor modifications.
----
This ticket significantly improves behavior when navigating to a non-
existing product, thanks Olemis! I did a bit of refactoring in
`process_request`, so please let me know if you spot any issues.
I'll just conclude by saying, more testing is needed, but from what I can
see:
* The permissions check:
{{{#!python
if pid:
req.perm('product', pid).require('PRODUCT_VIEW')
}}}
doesn't seem to have any effect after
`req.perm.require('PRODUCT_VIEW')`, as far as I could see (but I left it
in place for now).
* My previous statement seems to hold about
`/products/prod1/products/prod2` displaying an empty dashboard when the
user has permission to access `prod1` and regardless of whether they have
permission to access `prod2`, and may be something we want to avoid.
* Really what we need are some functional tests here, so the code can be
properly refactored!
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/561#comment:17>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
