Author: rjollos
Date: Thu Aug 8 08:52:38 2013
New Revision: 1511622
URL: http://svn.apache.org/r1511622
Log:
`multiproduct.env.ProductEnvironment`: Removed private `_href` variable, made
unnecessary by use of `lazy` decorator. Refs #595.
Modified:
bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py
bloodhound/trunk/bloodhound_multiproduct/tests/env.py
Modified: bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py
URL:
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py?rev=1511622&r1=1511621&r2=1511622&view=diff
==============================================================================
--- bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py (original)
+++ bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py Thu Aug 8
08:52:38 2013
@@ -348,7 +348,7 @@ class ProductEnvironment(Component, Comp
Product environments contain among other things:
- * configuration key-value pairs stored in the database,
+ * configuration key-value pairs stored in the database,
* product-aware clones of the wiki and ticket attachments files,
Product environments do not have:
@@ -542,7 +542,7 @@ class ProductEnvironment(Component, Comp
self.parent = env
self.product = product
self.systeminfo = []
- self._href = self._abs_href = None
+ self._abs_href = None
self.setup_config()
@@ -858,9 +858,7 @@ class ProductEnvironment(Component, Comp
@lazy
def href(self):
"""The application root path"""
- if not self._href:
- self._href = Href(urlsplit(self.abs_href.base)[2])
- return self._href
+ return Href(urlsplit(self.abs_href.base)[2])
@lazy
def abs_href(self):
Modified: bloodhound/trunk/bloodhound_multiproduct/tests/env.py
URL:
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/tests/env.py?rev=1511622&r1=1511621&r2=1511622&view=diff
==============================================================================
--- bloodhound/trunk/bloodhound_multiproduct/tests/env.py (original)
+++ bloodhound/trunk/bloodhound_multiproduct/tests/env.py Thu Aug 8 08:52:38
2013
@@ -486,6 +486,10 @@ class ProductEnvApiTestCase(Multiproduct
# Unregister class C as its fake module might break something else.
ComponentMeta._components.remove(C)
+ def test_href_is_lazy(self):
+ href = self.product_env.href
+ self.assertIs(href, self.product_env.href)
+
def test_path(self):
"""Testing env.path"""
self.assertEqual(self.product_env.path,
