#584: Missing .expander indicator in repository browser
------------------------+--------------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: review
Priority: major | Milestone: Release 8
Component: ui design | Version:
Resolution: | Keywords: vcs, browser
------------------------+--------------------------
Comment (by rjollos):
Replying to [ticket:584 olemis]:
> This makes inline navigation across the tree almost impossible . It
seems this is caused by the removal of browser.css stylesheet . At least
it is included in the web page which leads to `HTTP 404` ''Not Found''
error .
`browser.css` is being added back by
[browser:/trunk/bloodhound_theme/bhtheme/theme.py@1532641:438#L430
BloodhoundTheme._modify_browser], so it seems like we are expecting it to
be there.
After removing whitespace differences, I get the following diff of the
attached patch against `browser.css` from Trac 1.0.1:
{{{#!diff
--- ../../trac/trac/htdocs/css/browser.css 2013-09-18
22:51:26.752119104 -0700
+++ htdocs/css/browser.css 2013-10-17 09:20:43.923906999 -0700
@@ -12,13 +12,6 @@
#file-legend { margin-top: 3em; }
/* Browser */
-h1 { margin: 0; padding: 0 0 .5em }
-h1 :link, h1 :visited { border: none; }
-h1 :link, h1 :visited { color: #b00 }
-h1 .first:link, h1 .first:visited { color: #998 }
-h1 .sep { color: #666; padding: 0 .1em }
-h1 .pathentry { float: left; padding: 0 .1em }
-
#diffrev, #jumprev, #jumploc { float: right; font-size: 10px; margin: 0 0
0.6em 2em; }
#diffrev form, #jumprev form, #jumploc form { margin: 0 }
#diffrev input, #jumprev input, #jumploc select, #jumploc input {
@@ -72,38 +65,38 @@
}
table.dirlist td.name { width: 100%; white-space: nowrap }
table.dirlist td.name a.parent {
- background: url(../parent.png) 0 50% no-repeat;
+ background: url(../../common/parent.png) 0 50% no-repeat;
padding-left: 20px;
}
table.dirlist tr span.expander {
- background: url(../expander_normal.png) 0 50% no-repeat;
+ background: url(../../common/expander_normal.png) 0 50% no-repeat;
cursor: pointer;
padding-left: 8px;
margin-left: 4px;
}
table.dirlist tr span.expander:hover {
- background: url(../expander_normal_hover.png) 0 50% no-repeat;
+ background: url(../../common/expander_normal_hover.png) 0 50% no-
repeat;
}
table.dirlist tr.expanded span.expander {
- background: url(../expander_open.png) 0 50% no-repeat;
+ background: url(../../common/expander_open.png) 0 50% no-repeat;
padding-left: 12px;
margin-left: 0;
}
table.dirlist tr.expanded span.expander:hover {
- background: url(../expander_open_hover.png) 0 50% no-repeat;
+ background: url(../../common/expander_open_hover.png) 0 50% no-repeat;
}
table.dirlist td.name a.dir {
- background: url(../folder.png) 0 50% no-repeat;
+ background: url(../../common/folder.png) 0 50% no-repeat;
padding-left: 20px;
}
table.dirlist td.name a.file {
- background: url(../file.png) 0 50% no-repeat;
+ background: url(../../common/file.png) 0 50% no-repeat;
padding-left: 20px;
}
table.dirlist td.name a, table.dirlist td.rev a { border-bottom: none }
table.dirlist td.author, table.dirlist td.change { font-size: 85% }
table.dirlist td.rev a.chgset {
- background: url(../changeset.png) 100% 50% no-repeat;
+ background: url(../../common/changeset.png) 100% 50% no-repeat;
padding: 0 0 0 5px;
margin: 0 5px 0 0;
}
@@ -111,7 +104,7 @@
table.dirlist td.description > :first-child { margin-top: 0 }
table.dirlist td.description > :last-child { margin-bottom: 0 }
table.dirlist td span.loading {
- background: url(../loading.gif) 0 50% no-repeat;
+ background: url(../../common/loading.gif) 0 50% no-repeat;
padding-left: 20px;
font-style: italic
}
@@ -165,7 +158,7 @@
.chglist td.rev a { border-bottom: none }
.chglist td.rev a.chgset {
background-repeat: no-repeat;
- background-image: url(../changeset.png);
+ background-image: url(../../common/changeset.png);
background-position: 100% 50%;
padding: 0 0 0 5px;
margin: 0 5px 0 0;
@@ -214,21 +207,3 @@
#preview .image-file { overflow: hidden }
#preview .image-file img { max-width: 100% }
-/* Branch and tag labels */
-.chglist td.summary .branch, .chglist td.summary .tag,
-.browser .trac-tags .branch, .browser .trac-tags .tag {
- color: #777;
- font-size: 80%;
- background: #f6f6f6;
- border: 1px solid #ddd;
- margin: 0 0 0 .5em;
- padding: 0 .2em;
-}
-.chglist td.summary .head, .browser .trac-tags .head {
- background: #d0ffd0;
- border: 1px solid #9d9;
-}
-.chglist td.summary .tag, .browser .trac-tags .tag {
- background: #ffa;
- border: 1px solid #fe0;
-}
}}}
It looks like the `h1` styling was intentionally removed since it was
originally added over a
[http://trac.edgewall.org/browser/tags/trac-1.0.1/trac/htdocs/css/browser.css?annotate=blame&marks=14-20
broad range of revisions], but the block of styling //Branch and tag
labels// was not added until [trac 10433], and given that the patch
attached to this ticket was created 4 months ago, it seems likely that it
was based on a pre-0.13dev version of `browser.css`. Therefore, we'll
probably want to evaluate whether the additional //Branch and tag labels//
styling should be added in.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/584#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
