Author: rjollos Date: Tue Mar 4 05:17:01 2014 New Revision: 1573853 URL: http://svn.apache.org/r1573853 Log: 0.8dev: Validation that checked for open child tickets had reversed logic. Refs #746.
The validation now checks whether the source ticket //is a parent of// any open tickets. Modified: bloodhound/trunk/bloodhound_relations/bhrelations/api.py bloodhound/trunk/bloodhound_relations/bhrelations/tests/api.py Modified: bloodhound/trunk/bloodhound_relations/bhrelations/api.py URL: http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/bhrelations/api.py?rev=1573853&r1=1573852&r2=1573853&view=diff ============================================================================== --- bloodhound/trunk/bloodhound_relations/bhrelations/api.py (original) +++ bloodhound/trunk/bloodhound_relations/bhrelations/api.py Tue Mar 4 05:17:01 2014 @@ -545,7 +545,7 @@ class TicketRelationsSpecifics(Component operations = self._get_operations_for_action(req, ticket, action) if 'set_resolution' in operations: for relation in [r for r in self.rls.get_relations(ticket) - if r['type'] == self.rls.CHILDREN_RELATION_TYPE]: + if r['type'] == self.rls.PARENT_RELATION_TYPE]: child_ticket = \ self._create_ticket_by_full_id(relation['destination']) if child_ticket['status'] != 'closed': Modified: bloodhound/trunk/bloodhound_relations/bhrelations/tests/api.py URL: http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/bhrelations/tests/api.py?rev=1573853&r1=1573852&r2=1573853&view=diff ============================================================================== --- bloodhound/trunk/bloodhound_relations/bhrelations/tests/api.py (original) +++ bloodhound/trunk/bloodhound_relations/bhrelations/tests/api.py Tue Mar 4 05:17:01 2014 @@ -452,9 +452,9 @@ class ApiTestCase(BaseRelationsTestCase) t2 = self._insert_and_load_ticket("2", status='closed') # / | \ t3 = self._insert_and_load_ticket("3") # t2 t3 t4 t4 = self._insert_and_load_ticket("4") - self.relations_system.add(t2, t1, "parent") - self.relations_system.add(t3, t1, "parent") - self.relations_system.add(t4, t1, "parent") + self.relations_system.add(t1, t2, "parent") + self.relations_system.add(t1, t3, "parent") + self.relations_system.add(t1, t4, "parent") # A warning is be returned for each open ticket self.req.args["action"] = 'resolve'