#788: 'FacetCollector' object has no attribute 'offset'
----------------------+------------------------------------
  Reporter:  olemis   |      Owner:  rjollos
      Type:  defect   |     Status:  review
  Priority:  blocker  |  Milestone:  Release 8
 Component:  search   |    Version:  0.8.0dev
Resolution:           |   Keywords:  whoosh collector facet
----------------------+------------------------------------

Comment (by rjollos):

 You still haven't answered the question about which installation steps you
 followed. The version requirement in `setup.py` should be sufficient to
 enforce the package version in a production installation. It may not
 enforce the requirement when you install in development mode and update
 the source code. However, I don't think it's going to be worthwhile to add
 additional code simply to handle that case.

 So in short, I will consider installing the patch if you can describe a
 sequence of steps that would lead to the new Whoosh requirement not being
 installation in a //production installation//.  Otherwise, we certainly
 shouldn't be hard-coding the version in the source code, adding another
 point that must be maintained when the Whoosh requirement changes, and
 even if the hard-code version was removed I question the value of the
 patch.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/788#comment:15>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Reply via email to