Repository: bookkeeper Updated Branches: refs/heads/branch-4.3 b93ff769b -> f912141d2
BOOKKEEPER-809: Wrong metric on LedgerDeleteOp and LedgerOpenOp (Charles Xie via sijie) Project: http://git-wip-us.apache.org/repos/asf/bookkeeper/repo Commit: http://git-wip-us.apache.org/repos/asf/bookkeeper/commit/f912141d Tree: http://git-wip-us.apache.org/repos/asf/bookkeeper/tree/f912141d Diff: http://git-wip-us.apache.org/repos/asf/bookkeeper/diff/f912141d Branch: refs/heads/branch-4.3 Commit: f912141d2461f4528be561e788b93e69c844e075 Parents: b93ff76 Author: Sijie Guo <[email protected]> Authored: Fri Dec 5 22:09:15 2014 -0800 Committer: Sijie Guo <[email protected]> Committed: Fri Dec 5 22:09:15 2014 -0800 ---------------------------------------------------------------------- CHANGES.txt | 2 ++ .../main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java | 4 ++-- .../src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/bookkeeper/blob/f912141d/CHANGES.txt ---------------------------------------------------------------------- diff --git a/CHANGES.txt b/CHANGES.txt index 2a34068..12377a1 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -8,6 +8,8 @@ Release 4.3.1 - unreleased BOOKKEEPER-799: Distribution schedule coverage sets don't take gaps in response lists into account when writequorum > ackquorum (ivank) + BOOKKEEPER-809: Wrong metric on LedgerDeleteOp and LedgerOpenOp (Charles Xie via sijie) + IMPROVEMENTS: BOOKKEEPER-800: Expose whether a ledger is closed or not (ivank) http://git-wip-us.apache.org/repos/asf/bookkeeper/blob/f912141d/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java ---------------------------------------------------------------------- diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java index f8caa5b..b41d15a 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java @@ -81,9 +81,9 @@ class LedgerDeleteOp extends OrderedSafeGenericCallback<Void> { @Override public void safeOperationComplete(int rc, Void result) { if (BKException.Code.OK != rc) { - deleteOpLogger.registerFailedEvent(startTime); + deleteOpLogger.registerFailedEvent(MathUtils.elapsedMSec(startTime)); } else { - deleteOpLogger.registerSuccessfulEvent(startTime); + deleteOpLogger.registerSuccessfulEvent(MathUtils.elapsedMSec(startTime)); } cb.deleteComplete(rc, this.ctx); } http://git-wip-us.apache.org/repos/asf/bookkeeper/blob/f912141d/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java ---------------------------------------------------------------------- diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java index 4df89ea..eb145bd 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java @@ -196,9 +196,9 @@ class LedgerOpenOp implements GenericCallback<LedgerMetadata> { void openComplete(int rc, LedgerHandle lh) { if (BKException.Code.OK != rc) { - openOpLogger.registerFailedEvent(startTime); + openOpLogger.registerFailedEvent(MathUtils.elapsedMSec(startTime)); } else { - openOpLogger.registerSuccessfulEvent(startTime); + openOpLogger.registerSuccessfulEvent(MathUtils.elapsedMSec(startTime)); } cb.openComplete(rc, lh, ctx); }
