This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 3908d9c  BOOKKEEPER-1103: Fix LedgerMetadataCreateTest random id loop
3908d9c is described below

commit 3908d9ce6a5530ae2ae8526b9988b983423c026c
Author: Samuel Just <[email protected]>
AuthorDate: Fri Jul 28 13:34:58 2017 -0700

    BOOKKEEPER-1103: Fix LedgerMetadataCreateTest random id loop
    
    The previous version would loop indefinitely upon collision.
    
    Signed-off-by: Samuel Just <sjustsalesforce.com>
    
    Author: Samuel Just <[email protected]>
    
    Reviewers: Enrico Olivelli <[email protected]>, Matteo Merli 
<[email protected]>
    
    This closes #303 from athanatos/forupstream/BOOKKEEPER-1103
---
 .../java/org/apache/bookkeeper/meta/LedgerMetadataCreationTest.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerMetadataCreationTest.java
 
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerMetadataCreationTest.java
index 7417f99..d90b3f9 100644
--- 
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerMetadataCreationTest.java
+++ 
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerMetadataCreationTest.java
@@ -76,8 +76,8 @@ public class LedgerMetadataCreationTest extends 
LedgerManagerTestCase {
                     long ledgerId = -1;
                     try {
                         if (randomLedgerId) {
-                            ledgerId = Math.abs(rand.nextLong());
                             do {
+                                ledgerId = Math.abs(rand.nextLong());
                                 if 
(!baseClientConf.getLedgerManagerFactoryClass()
                                         
.equals(LongHierarchicalLedgerManagerFactory.class)) {
                                     /*

-- 
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].

Reply via email to