This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new f207d2d Fix FlakyTest TestRegionAwareEnsemblePlacementPolicy
f207d2d is described below
commit f207d2d9f432d43e2461f260056b91f1ba4803e1
Author: Sijie Guo <[email protected]>
AuthorDate: Wed Dec 13 13:40:48 2017 -0800
Fix FlakyTest TestRegionAwareEnsemblePlacementPolicy
Descriptions of the changes in this PR:
include all possible resolved hostnames into the static dns resolver for
region aware testing.
Author: Sijie Guo <[email protected]>
Reviewers: Enrico Olivelli <[email protected]>, Jia Zhai <None>
This closes #837 from sijie/fix_regionaware
---
.../bookkeeper/client/TestRegionAwareEnsemblePlacementPolicy.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestRegionAwareEnsemblePlacementPolicy.java
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestRegionAwareEnsemblePlacementPolicy.java
index d29499e..1dcf0e1 100644
---
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestRegionAwareEnsemblePlacementPolicy.java
+++
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestRegionAwareEnsemblePlacementPolicy.java
@@ -29,9 +29,7 @@ import static
org.apache.bookkeeper.client.RoundRobinDistributionSchedule.writeS
import static
org.apache.bookkeeper.feature.SettableFeatureProvider.DISABLE_ALL;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
-
import io.netty.util.HashedWheelTimer;
-
import java.net.InetAddress;
import java.util.ArrayList;
import java.util.HashMap;
@@ -40,9 +38,7 @@ import java.util.List;
import java.util.Optional;
import java.util.Set;
import java.util.concurrent.TimeUnit;
-
import junit.framework.TestCase;
-
import org.apache.bookkeeper.client.BKException.BKNotEnoughBookiesException;
import org.apache.bookkeeper.conf.ClientConfiguration;
import org.apache.bookkeeper.feature.FeatureProvider;
@@ -75,6 +71,10 @@ public class TestRegionAwareEnsemblePlacementPolicy extends
TestCase {
static void updateMyRack(String rack) throws Exception {
StaticDNSResolver.addNodeToRack(InetAddress.getLocalHost().getHostAddress(),
rack);
StaticDNSResolver.addNodeToRack(InetAddress.getLocalHost().getHostName(), rack);
+ BookieSocketAddress bookieAddress = new BookieSocketAddress(
+ InetAddress.getLocalHost().getHostAddress(), 0);
+
StaticDNSResolver.addNodeToRack(bookieAddress.getSocketAddress().getHostName(),
rack);
+
StaticDNSResolver.addNodeToRack(bookieAddress.getSocketAddress().getAddress().getHostAddress(),
rack);
StaticDNSResolver.addNodeToRack("127.0.0.1", rack);
StaticDNSResolver.addNodeToRack("localhost", rack);
}
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
