This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 5ea3110 BookieProtoEncoding: log messages at TRACE rather than DEBUG
5ea3110 is described below
commit 5ea3110e35e0694fc8ed2218698888041eaf23e8
Author: Samuel Just <[email protected]>
AuthorDate: Thu Dec 21 21:44:51 2017 -0800
BookieProtoEncoding: log messages at TRACE rather than DEBUG
Logging them at debug tends to make logging at DEBUG level pretty
intractable, log them at TRACE instead.
(bug W-4166441)
Signed-off-by: Samuel Just <sjustsalesforce.com>
Author: Samuel Just <[email protected]>
Reviewers: Sijie Guo <[email protected]>
This closes #909 from athanatos/forupstream/small-fixes-1/trace
---
.../org/apache/bookkeeper/proto/BookieProtoEncoding.java | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java
index 18cecf8..00db67c 100644
---
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java
+++
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtoEncoding.java
@@ -385,6 +385,9 @@ public class BookieProtoEncoding {
@Override
protected void encode(ChannelHandlerContext ctx, Object msg,
List<Object> out) throws Exception {
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("Encode request {} to channel {}.", msg,
ctx.channel());
+ }
if (msg instanceof BookkeeperProtocol.Request) {
out.add(reqV3.encode(msg, ctx.alloc()));
} else if (msg instanceof BookieProtocol.Request) {
@@ -413,8 +416,8 @@ public class BookieProtoEncoding {
@Override
protected void decode(ChannelHandlerContext ctx, Object msg,
List<Object> out) throws Exception {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Received request {} from channel {} to decode.",
msg, ctx.channel());
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("Received request {} from channel {} to decode.",
msg, ctx.channel());
}
if (!(msg instanceof ByteBuf)) {
out.add(msg);
@@ -453,8 +456,8 @@ public class BookieProtoEncoding {
@Override
protected void encode(ChannelHandlerContext ctx, Object msg,
List<Object> out)
throws Exception {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Encode response {} to channel {}.", msg,
ctx.channel());
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("Encode response {} to channel {}.", msg,
ctx.channel());
}
if (msg instanceof BookkeeperProtocol.Response) {
out.add(repV3.encode(msg, ctx.alloc()));
@@ -484,8 +487,8 @@ public class BookieProtoEncoding {
@Override
protected void decode(ChannelHandlerContext ctx, Object msg,
List<Object> out) throws Exception {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Received response {} from channel {} to decode.",
msg, ctx.channel());
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("Received response {} from channel {} to decode.",
msg, ctx.channel());
}
if (!(msg instanceof ByteBuf)) {
out.add(msg);
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
