This is an automated email from the ASF dual-hosted git repository.
zhaijia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new f83efd4 Run checkstyle plugin at validate phase
f83efd4 is described below
commit f83efd4fe6a4a32ffbccb49d1905d50e8013f15b
Author: Sijie Guo <[email protected]>
AuthorDate: Fri Feb 2 12:11:30 2018 +0800
Run checkstyle plugin at validate phase
Descriptions of the changes in this PR:
Most of the modules run checkstyle plugin at validate phase. However a few
modules are still running at `test-compile` phase.
Update the checkstyle plugins in those modules to run at validate phase. So
the behavior is consistent across the project.
Author: Sijie Guo <[email protected]>
Reviewers: Jia Zhai <None>
This closes #1098 from sijie/run_checkstyle_at_validate_phase
---
tests/bookkeeper-server-shaded-artifact-test/pom.xml | 3 ++-
tests/bookkeeper-server-shaded-test/pom.xml | 3 ++-
tests/bookkeeper-server-tests-shaded-test/pom.xml | 3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/tests/bookkeeper-server-shaded-artifact-test/pom.xml
b/tests/bookkeeper-server-shaded-artifact-test/pom.xml
index aa40a12..73352af 100644
--- a/tests/bookkeeper-server-shaded-artifact-test/pom.xml
+++ b/tests/bookkeeper-server-shaded-artifact-test/pom.xml
@@ -85,7 +85,8 @@
</configuration>
<executions>
<execution>
- <phase>test-compile</phase>
+ <id>checkstyle</id>
+ <phase>validate</phase>
<goals>
<goal>check</goal>
</goals>
diff --git a/tests/bookkeeper-server-shaded-test/pom.xml
b/tests/bookkeeper-server-shaded-test/pom.xml
index ec75a53..d72d6ca 100644
--- a/tests/bookkeeper-server-shaded-test/pom.xml
+++ b/tests/bookkeeper-server-shaded-test/pom.xml
@@ -84,7 +84,8 @@
</configuration>
<executions>
<execution>
- <phase>test-compile</phase>
+ <id>checkstyle</id>
+ <phase>validate</phase>
<goals>
<goal>check</goal>
</goals>
diff --git a/tests/bookkeeper-server-tests-shaded-test/pom.xml
b/tests/bookkeeper-server-tests-shaded-test/pom.xml
index 3ee3fdf..5418f5a 100644
--- a/tests/bookkeeper-server-tests-shaded-test/pom.xml
+++ b/tests/bookkeeper-server-tests-shaded-test/pom.xml
@@ -104,7 +104,8 @@
</configuration>
<executions>
<execution>
- <phase>test-compile</phase>
+ <id>checkstyle</id>
+ <phase>validate</phase>
<goals>
<goal>check</goal>
</goals>
--
To stop receiving notification emails like this one, please contact
[email protected].
