[bookkeeper] branch master updated: Fix test regression due to change in default ledger manager

[ivank]

This is an automated email from the ASF dual-hosted git repository.

ivank pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new eae32f6  Fix test regression due to change in default ledger manager
eae32f6 is described below

commit eae32f6b667f0842897f4ca151cc7b7d31ef2e91
Author: Ivan Kelly <iv...@apache.org>
AuthorDate: Tue Feb 13 15:09:32 2018 +0100

    Fix test regression due to change in default ledger manager
    
    TestBenchmark#testReadThroughputLatency() regressed due to the change
    in 3ddc5db, where the default ledger manager was changed from flat to
    hierarchical.
    
    The fix is to use flat for this test. I've also cleaned up the test a
    little, and added some code to the benchmark to make the test run
    faster.
    
    Author: Ivan Kelly <iv...@apache.org>
    
    Reviewers: Enrico Olivelli <eolive...@gmail.com>, Sijie Guo 
<si...@apache.org>
    
    This closes #1137 from ivankelly/bench-broke
---
 .../test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java  | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git 
a/bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java
 
b/bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java
index e3b1124..205c4ab 100644
--- 
a/bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java
+++ 
b/bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java
@@ -25,6 +25,7 @@ import org.apache.bookkeeper.net.BookieSocketAddress;
 import org.apache.bookkeeper.test.BookKeeperClusterTestCase;
 import org.junit.Test;
 import org.junit.Assert;
+import org.junit.Before;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -38,6 +39,13 @@ public class TestBenchmark extends BookKeeperClusterTestCase 
{
         super(5);
     }
 
+    @Before
+    public void setUp() throws Exception {
+        
baseConf.setLedgerManagerFactoryClassName("org.apache.bookkeeper.meta.FlatLedgerManagerFactory");
+        
baseClientConf.setLedgerManagerFactoryClassName("org.apache.bookkeeper.meta.FlatLedgerManagerFactory");
+        super.setUp();
+    }
+
     @Test
     public void testThroughputLatency() throws Exception {
         String latencyFile = System.getProperty("test.latency.file", 
"latencyDump.dat");

-- 
To stop receiving notification emails like this one, please contact
iv...@apache.org.