This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 9aececa Close bookkeeper client used in format
9aececa is described below
commit 9aececa466ed1bc2be731543bd549a51d7c8ed3c
Author: Ivan Kelly <[email protected]>
AuthorDate: Fri Mar 16 11:19:49 2018 -0700
Close bookkeeper client used in format
Otherwise, the executors threads could keep the process calling it
alive. This isn't a problem for BookieShell, since it does a System.exit,
but it currently is for pulsar metadata cluster format.
Author: Ivan Kelly <[email protected]>
Reviewers: Enrico Olivelli <[email protected]>, Matteo Merli
<[email protected]>, Sijie Guo <[email protected]>
This closes #1269 from ivankelly/close-format-client
---
.../src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
index d0078f4..7671721 100644
---
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
+++
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
@@ -1160,8 +1160,9 @@ public class BookKeeperAdmin implements AutoCloseable {
return false;
}
- BookKeeper bkc = new BookKeeper(new ClientConfiguration(conf));
- bkc.ledgerManagerFactory.format(conf,
bkc.getMetadataClientDriver().getLayoutManager());
+ try (BookKeeper bkc = new BookKeeper(new
ClientConfiguration(conf))) {
+ bkc.ledgerManagerFactory.format(conf,
bkc.getMetadataClientDriver().getLayoutManager());
+ }
return rm.format();
} catch (Exception e) {
--
To stop receiving notification emails like this one, please contact
[email protected].
