[bookkeeper] branch master updated: Implement `toString` method for CheckpointList and BufferedLogChannel

[zhaijia]

This is an automated email from the ASF dual-hosted git repository.

zhaijia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new c4a4318  Implement `toString` method for CheckpointList and 
BufferedLogChannel
c4a4318 is described below

commit c4a4318fcd308351b66c39599187c2e79fb0687a
Author: Sijie Guo <si...@apache.org>
AuthorDate: Tue Mar 20 22:54:40 2018 +0800

    Implement `toString` method for CheckpointList and BufferedLogChannel
    
    Descriptions of the changes in this PR:
    
    ```
    Flushing entry logger 102 back to filesystem, pending for syncing entry 
loggers : [org.apache.bookkeeper.bookie.EntryLogger$BufferedLogChannel7d98c184].
    
    org.apache.bookkeeper.bookie.SortedLedgerStorage - Reached size 
org.apache.bookkeeper.bookie.CheckpointSourceList$CheckpointListd2c00ea5
    ```
    
    `CheckpointList` and `BufferedLogChannel` is missing `toString` 
implementation.
    
    Author: Sijie Guo <si...@apache.org>
    
    Reviewers: Enrico Olivelli <eolive...@gmail.com>, Jia Zhai <None>
    
    This closes #1278 from sijie/fix_tostring_issue
---
 .../java/org/apache/bookkeeper/bookie/CheckpointSource.java  | 12 +++++++++++-
 .../org/apache/bookkeeper/bookie/CheckpointSourceList.java   |  8 ++++++++
 .../main/java/org/apache/bookkeeper/bookie/EntryLogger.java  |  9 +++++++++
 3 files changed, 28 insertions(+), 1 deletion(-)

diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSource.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSource.java
index e7043bd..a6b41f4 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSource.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSource.java
@@ -27,7 +27,7 @@ public interface CheckpointSource {
     /**
      * A checkpoint presented a time point. All entries added before this 
checkpoint are already persisted.
      */
-    public interface Checkpoint extends Comparable<Checkpoint> {
+    interface Checkpoint extends Comparable<Checkpoint> {
 
         Checkpoint MAX = new Checkpoint() {
 
@@ -44,6 +44,11 @@ public interface CheckpointSource {
                 return this == o;
             }
 
+            @Override
+            public String toString() {
+                return "MAX";
+            }
+
         };
 
         Checkpoint MIN = new Checkpoint() {
@@ -59,6 +64,11 @@ public interface CheckpointSource {
             public boolean equals(Object o) {
                 return this == o;
             }
+
+            @Override
+            public String toString() {
+                return "MIN";
+            }
         };
     }
 
diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSourceList.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSourceList.java
index 64c6021..0c156ab 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSourceList.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSourceList.java
@@ -19,6 +19,7 @@ package org.apache.bookkeeper.bookie;
 
 import static com.google.common.base.Preconditions.checkArgument;
 
+import com.google.common.base.MoreObjects;
 import com.google.common.base.Objects;
 import com.google.common.collect.Lists;
 import java.io.IOException;
@@ -109,6 +110,13 @@ public class CheckpointSourceList implements 
CheckpointSource {
             return 0;
         }
 
+        @Override
+        public String toString() {
+            return MoreObjects.toStringHelper(CheckpointList.class)
+                .add("checkpoints", checkpoints)
+                .toString();
+        }
+
     }
 
 }
diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
index 5754009..0df8607 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
@@ -25,6 +25,7 @@ import static com.google.common.base.Charsets.UTF_8;
 import static 
org.apache.bookkeeper.bookie.TransactionalEntryLogCompactor.COMPACTING_SUFFIX;
 import static 
org.apache.bookkeeper.util.BookKeeperConstants.MAX_LOG_SIZE_LIMIT;
 
+import com.google.common.base.MoreObjects;
 import com.google.common.collect.MapMaker;
 import com.google.common.collect.Sets;
 
@@ -114,6 +115,14 @@ public class EntryLogger {
         public ConcurrentLongLongHashMap getLedgersMap() {
             return entryLogMetadata.getLedgersMap();
         }
+
+        @Override
+        public String toString() {
+            return MoreObjects.toStringHelper(BufferedChannel.class)
+                .add("logId", logId)
+                .add("logFile", logFile)
+                .toString();
+        }
     }
 
     volatile File currentDir;

-- 
To stop receiving notification emails like this one, please contact
zhai...@apache.org.