This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 0b01c12 Fix format problem of BP-32
0b01c12 is described below
commit 0b01c125df58dc85d5f965ce151a278d37ec6d3c
Author: Sijie Guo <[email protected]>
AuthorDate: Thu May 3 12:31:34 2018 -0700
Fix format problem of BP-32
Also mark BP-32 as accepted.
Author: Sijie Guo <[email protected]>
Reviewers: Charan Reddy Guttapalem <[email protected]>, Enrico
Olivelli <[email protected]>
This closes #1383 from sijie/fix_typos
---
site/bps/BP-32-advisory-write-close.md | 4 +++-
site/community/bookkeeper_proposals.md | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/site/bps/BP-32-advisory-write-close.md
b/site/bps/BP-32-advisory-write-close.md
index f3d0ffc..afe8e97 100644
--- a/site/bps/BP-32-advisory-write-close.md
+++ b/site/bps/BP-32-advisory-write-close.md
@@ -7,7 +7,7 @@ release: N/A
### Motivation
-With entrylog per ledger feature
(https://github.com/apache/bookkeeper/issues/570) there will be dedicated
entrylog for each ledger and it provides EntryLogManagerForEntryLogPerLedger
(EntryLogManager). Since there is going to be entrylog per ledger, with the
current Bookie implementation there is no way for
EntryLogManagerForEntryLogPerLedger (EntryLogManager) to know when the entrylog
is writeclosed, so that entrylog for the active ledger can be rotated. So it
would be ideal to have ex [...]
+With [entrylog per ledger
feature](https://github.com/apache/bookkeeper/issues/570) there will be
dedicated entrylog for each ledger and it provides
EntryLogManagerForEntryLogPerLedger (EntryLogManager). Since there is going to
be entrylog per ledger, with the current Bookie implementation there is no way
for EntryLogManagerForEntryLogPerLedger (EntryLogManager) to know when the
entrylog is writeclosed, so that entrylog for the active ledger can be rotated.
So it would be ideal to have e [...]
### Proposed Changes
@@ -29,6 +29,7 @@ EntryLogManagerForEntryLogPerLedger is the class which is
last layer in the stac
As explained above, this advisory write close should be transparent to
Bookkeeper API user, this should be piggybagged in writehandle close call and
other internal Bookie / BookieClient internal class methods
(ReadEntryProcessorV3.readrequest and LedgerFragmentReplicator). But this
feature introduces new protobuf message between Client and Bookie.
+```
message WriteCloseRequest {
required int64 ledgerId = 1;
required bytes masterKey = 2;
@@ -38,6 +39,7 @@ message WriteCloseResponse {
required StatusCode status = 1;
required int64 ledgerId = 2;
}
+```
### Compatibility, Deprecation, and Migration Plan
diff --git a/site/community/bookkeeper_proposals.md
b/site/community/bookkeeper_proposals.md
index b9f4396..dc2fe99 100644
--- a/site/community/bookkeeper_proposals.md
+++ b/site/community/bookkeeper_proposals.md
@@ -103,7 +103,7 @@ Proposal | State
[BP-29: Metadata API module](../../bps/BP-29-metadata-store-api-module) |
Accepted
[BP-30: BookKeeper Table
Service](https://docs.google.com/document/d/155xAwWv5IdOitHh1NVMEwCMGgB28M3FyMiQSxEpjE-Y/edit#heading=h.56rbh52koe3f)
| Accepted
[BP-31: BookKeeper Durability Anchor](../../bps/BP-31-durability) | Accepted
-[BP-32: Advisory (optimistic) write
close](../../bps/BP-32-advisory-write-close) | Draft
+[BP-32: Advisory (optimistic) write
close](../../bps/BP-32-advisory-write-close) | Accepted
### Adopted
--
To stop receiving notification emails like this one, please contact
[email protected].
