This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 92525c2  Fix TestCompatUpgrade
92525c2 is described below

commit 92525c2ae30f41badb3986e3bc69de3aceb67e2d
Author: Sijie Guo <si...@apache.org>
AuthorDate: Thu May 3 15:47:46 2018 -0700

    Fix TestCompatUpgrade
    
    Descriptions of the changes in this PR:
    
    *Motivation*
    
     #1352 update the BC tests to include newer versions, however it removes 
the flags that used for 4.6.0 to handle badly shutdown.
     This change makes the BC tests become very flaky.
    
    *Solution*
    
    - apply `badlyshutdown` flag to both from 4.6.0 to 4.6.1 and from 4.6.1 to 
4.6.2 upgrade
    
    Author: Sijie Guo <si...@apache.org>
    
    Reviewers: Matteo Merli <mme...@apache.org>
    
    This closes #1386 from sijie/vagrant_files
---
 .../apache/bookkeeper/tests/backwardcompat/TestCompatUpgrade.groovy | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/tests/backward-compat/upgrade/src/test/groovy/org/apache/bookkeeper/tests/backwardcompat/TestCompatUpgrade.groovy
 
b/tests/backward-compat/upgrade/src/test/groovy/org/apache/bookkeeper/tests/backwardcompat/TestCompatUpgrade.groovy
index 8e0d8d7..940501d 100644
--- 
a/tests/backward-compat/upgrade/src/test/groovy/org/apache/bookkeeper/tests/backwardcompat/TestCompatUpgrade.groovy
+++ 
b/tests/backward-compat/upgrade/src/test/groovy/org/apache/bookkeeper/tests/backwardcompat/TestCompatUpgrade.groovy
@@ -178,12 +178,12 @@ class TestCompatUpgrade {
 
     @Test
     public void test460to461() throws Exception {
-        testUpgrade("4.6.0", "4.6.1")
+        testUpgrade("4.6.0", "4.6.1", false, true)
     }
 
     @Test
     public void test461to462() throws Exception {
-        testUpgrade("4.6.1", "4.6.2")
+        testUpgrade("4.6.1", "4.6.2", false, true)
     }
 
     @Test
@@ -193,6 +193,6 @@ class TestCompatUpgrade {
 
     @Test
     public void test470toCurrentMaster() throws Exception {
-        testUpgrade("4.7.0", System.getProperty("currentVersion"), false, true)
+        testUpgrade("4.7.0", System.getProperty("currentVersion"))
     }
 }

-- 
To stop receiving notification emails like this one, please contact
si...@apache.org.

Reply via email to