This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push: new 0d862fa Use isEmpty method instead of size check 0d862fa is described below commit 0d862fa42792301f26127addd5cc5a6a0114ce9b Author: Ali Ahmed <alahmed...@gmail.com> AuthorDate: Tue May 15 13:55:36 2018 +0200 Use isEmpty method instead of size check In HTTP ListLedgerService use is Empty instead of size check. Author: Ali Ahmed <alahmed...@gmail.com> Reviewers: Enrico Olivelli <eolive...@gmail.com>, Sijie Guo <si...@apache.org> This closes #1371 from aahmed-se/minorRefactor --- .../org/apache/bookkeeper/server/http/service/ListLedgerService.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/ListLedgerService.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/ListLedgerService.java index 1023d6b..758af70 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/ListLedgerService.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/ListLedgerService.java @@ -142,13 +142,13 @@ public class ListLedgerService implements HttpEndpointService { } } if (futures.size() >= LIST_LEDGER_BATCH_SIZE) { - while (futures.size() > 0) { + while (!futures.isEmpty()) { ReadLedgerMetadataCallback cb = futures.remove(0); keepLedgerMetadata(cb, output); } } } - while (futures.size() > 0) { + while (!futures.isEmpty()) { ReadLedgerMetadataCallback cb = futures.remove(0); keepLedgerMetadata(cb, output); } -- To stop receiving notification emails like this one, please contact eolive...@apache.org.