[bookkeeper] branch branch-4.8 updated: ISSUE #1528: logging "No network topology script is found when using script based DNS resolver" can be noisy and misleading.

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch branch-4.8
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/branch-4.8 by this push:
     new a062bf4  ISSUE #1528: logging "No network topology script is found 
when using script based DNS resolver" can be noisy and misleading.
a062bf4 is described below

commit a062bf4e490e3dfb7684b366ec6c460c2d413fb7
Author: Sijie Guo <si...@apache.org>
AuthorDate: Thu Aug 16 18:40:18 2018 -0700

    ISSUE #1528: logging "No network topology script is found when using script 
based DNS resolver" can be noisy and misleading.
    
    Descriptions of the changes in this PR:
    
     ### Motivation
    
    "No network topology script is found when using script based DNS resolver" 
is misleading and noisy.
    
     ### Changes
    
    Only log the error message but not the stack trace.
    
    Master Issue: #1528
    
    Author: Sijie Guo <si...@apache.org>
    
    Reviewers: Enrico Olivelli <eolive...@gmail.com>
    
    This closes #1605 from sijie/fix_log_message, closes #1528
    
    (cherry picked from commit d57cc6679b4181e514d04e8f3f1d7e598308d78f)
    Signed-off-by: Sijie Guo <si...@apache.org>
---
 .../apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
index 13efa5c..1d587d0 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
@@ -322,7 +322,8 @@ public class RackawareEnsemblePlacementPolicyImpl extends 
TopologyAwareEnsembleP
                     ((RackChangeNotifier) 
dnsResolver).registerRackChangeListener(this);
                 }
             } catch (RuntimeException re) {
-                LOG.info("Failed to initialize DNS Resolver {}, used default 
subnet resolver.", dnsResolverName, re);
+                LOG.info("Failed to initialize DNS Resolver {}, used default 
subnet resolver : {}",
+                    dnsResolverName, re, re.getMessage());
                 dnsResolver = new DefaultResolver(() -> this.getDefaultRack());
             }
         }