This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch branch-4.7
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/branch-4.7 by this push:
     new fa3d7c8  Typo in bookie request processor read handling
fa3d7c8 is described below

commit fa3d7c85a85a5f4113834c7ca09f276ad57ec79b
Author: Ivan Kelly <[email protected]>
AuthorDate: Thu Aug 16 18:42:10 2018 -0700

    Typo in bookie request processor read handling
    
    The response in the case of overload should take the ledgerId and
    entryId from the read request.
    
    Author: Ivan Kelly <[email protected]>
    
    Reviewers: Enrico Olivelli <[email protected]>, Sijie Guo 
<[email protected]>
    
    This closes #1590 from ivankelly/request-processor-typo
    
    (cherry picked from commit 987f8046d9f253354c512bd2aa32307ff9ed1019)
    Signed-off-by: Sijie Guo <[email protected]>
---
 .../main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
index edb8924..299031c 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java
@@ -406,8 +406,8 @@ public class BookieRequestProcessor implements 
RequestProcessor {
                               r.getReadRequest().getLedgerId(), 
r.getReadRequest().getEntryId());
                 }
                 BookkeeperProtocol.ReadResponse.Builder readResponse = 
BookkeeperProtocol.ReadResponse.newBuilder()
-                    .setLedgerId(r.getAddRequest().getLedgerId())
-                    .setEntryId(r.getAddRequest().getEntryId())
+                    .setLedgerId(r.getReadRequest().getLedgerId())
+                    .setEntryId(r.getReadRequest().getEntryId())
                     .setStatus(BookkeeperProtocol.StatusCode.ETOOMANYREQUESTS);
                 BookkeeperProtocol.Response.Builder response = 
BookkeeperProtocol.Response.newBuilder()
                     .setHeader(read.getHeader())

Reply via email to