This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push: new 052908e Remove unnecessary log statement in LedgerDirsManager.getWritableLedgerDirs 052908e is described below commit 052908ef30818d9f1e6be56bf3a3e3083c5bd6fb Author: cguttapalem <cguttapa...@salesforce.com> AuthorDate: Mon Sep 10 13:20:45 2018 -0700 Remove unnecessary log statement in LedgerDirsManager.getWritableLedgerDirs Descriptions of the changes in this PR: ### Motivation - when Bookie reaches diskusage threshold, LedgerDirsMonitor for every diskCheckInterval it logs NoWritableLedgerDirException call stack and message "All ledger directories are non writable". ### Changes So remove unneccessary log statement in LedgerDirsManager.getWritableLedgerDirs and let the caller deal with the thrown exception. Author: cguttapalem <cguttapa...@salesforce.com> Reviewers: Andrey Yegorov <None>, Sijie Guo <si...@apache.org> This closes #1670 from reddycharan/fixdirsmonitorlog --- .../src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java | 1 - .../src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java index cdaa668..5fb8215 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java @@ -157,7 +157,6 @@ public class LedgerDirsManager { String errMsg = "All ledger directories are non writable"; NoWritableLedgerDirException e = new NoWritableLedgerDirException( errMsg); - LOG.error(errMsg, e); throw e; } return writableLedgerDirectories; diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java index 4ef02fa..fedebb7 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsMonitor.java @@ -108,6 +108,7 @@ class LedgerDirsMonitor { // bookie cannot get writable dir but considered to be writable ldm.getWritableLedgerDirs(); } catch (NoWritableLedgerDirException e) { + LOG.warn("LedgerDirsMonitor check process: All ledger directories are non writable"); boolean highPriorityWritesAllowed = true; try { // disk check can be frequent, so disable 'loggingNoWritable' to avoid log flooding.