This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new af24652 Enable storeSystemTimeAsLedgerUnderreplicatedMarkTime
af24652 is described below
commit af246529b0728087b1c65a50b919abe7d4b5103f
Author: Charan Reddy Guttapalem <[email protected]>
AuthorDate: Mon Sep 24 00:18:21 2018 -0700
Enable storeSystemTimeAsLedgerUnderreplicatedMarkTime
Descriptions of the changes in this PR:
- Enable the Auditor to use system time as underreplicated ledger mark time.
If this is enabled, Auditor will write a ctime field into the
underreplicated ledger znode.
https://github.com/apache/bookkeeper/commit/f4094c4992d5b22630fa633085a00a9152b87ffe
introduced feature to Record ctime for underreplicated ledger mark time.
Author: Sijie Guo <[email protected]>
Author: Qi Wang <[email protected]>
Author: cguttapalem <[email protected]>
Author: Charan Reddy Guttapalem <[email protected]>
Reviewers: Sijie Guo <[email protected]>, Enrico Olivelli
<[email protected]>
This closes #1692 from reddycharan/enablectime
---
.../src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java | 2 +-
conf/bk_server.conf | 2 +-
site/_data/config/bk_server.yaml | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
index 666b377..a3c47ab 100644
---
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
+++
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
@@ -851,7 +851,7 @@ public abstract class AbstractConfiguration<T extends
AbstractConfiguration>
* underreplicated ledger mark time.
*/
public boolean getStoreSystemTimeAsLedgerUnderreplicatedMarkTime() {
- return
getBoolean(STORE_SYSTEMTIME_AS_LEDGER_UNDERREPLICATED_MARK_TIME, false);
+ return
getBoolean(STORE_SYSTEMTIME_AS_LEDGER_UNDERREPLICATED_MARK_TIME, true);
}
/**
diff --git a/conf/bk_server.conf b/conf/bk_server.conf
index 93c12a1..97404fb 100755
--- a/conf/bk_server.conf
+++ b/conf/bk_server.conf
@@ -911,7 +911,7 @@ zkEnableSecurity=false
# Enable the Auditor to use system time as underreplicated ledger mark time.
# If this is enabled, Auditor will write a ctime field into the
underreplicated ledger znode.
-# storeSystemTimeAsLedgerUnderreplicatedMarkTime=false
+# storeSystemTimeAsLedgerUnderreplicatedMarkTime=true
#############################################################################
## Replication Worker settings
diff --git a/site/_data/config/bk_server.yaml b/site/_data/config/bk_server.yaml
index 991d6f1..b60bfbf 100644
--- a/site/_data/config/bk_server.yaml
+++ b/site/_data/config/bk_server.yaml
@@ -648,6 +648,7 @@ groups:
default: 0
- param: storeSystemTimeAsLedgerUnderreplicatedMarkTime
description: Enable the Auditor to use system time as underreplicated
ledger mark time. If this is enabled, Auditor will write a ctime field into the
underreplicated ledger znode.
+ default: true
- name: AutoRecovery replication worker settings
params:
