This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new b67e8b2 [PYTHON] Fix python client version
b67e8b2 is described below
commit b67e8b262e3dbf77a7ef5f13c2e22bd191c85d00
Author: Sijie Guo <[email protected]>
AuthorDate: Thu Feb 28 23:13:21 2019 +0800
[PYTHON] Fix python client version
Descriptions of the changes in this PR:
*Motivation*
pip doesn't work with '-SNAPSHOT'. Use `-alpha-0` instead of `-SNAPSHOT`
for python.
*Modifications*
- update setup.py file
- update release guide
Reviewers: Jia Zhai <[email protected]>
This closes #1954 from sijie/fix_python_version
---
site/community/release_guide.md | 7 ++++---
stream/clients/python/setup.py | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/site/community/release_guide.md b/site/community/release_guide.md
index bb5834d..c8a05a3 100644
--- a/site/community/release_guide.md
+++ b/site/community/release_guide.md
@@ -169,7 +169,7 @@ The list of release-blocking issues is available at the
[milestones page](https:
Before cutting a release, you need to update the python client version in
[setup.py](https://github.com/apache/bookkeeper/blob/master/stream/clients/python/setup.py#L22)
from `SNAPSHOT` version to a release version and get the change merge to
master. For example,
-in release 4.10.0, you need to change the version from `4.10.0-SNAPSHOT` to
`4.10.0`.
+in release 4.10.0, you need to change the version from `4.10.0-alpha-0` to
`4.10.0`.
### Review Release Notes in Github
@@ -625,10 +625,11 @@ Example PR:
[release-4.7.0](https://github.com/apache/bookkeeper/pull/1350)
If you are doing a major release, you need to update the python client version
to next major development version in master
and next minor development version in the branch. For example, if you are
doing 4.9.0 release, you need to bump the version
-in master to `4.10.0-SNAPSHOT`, and the version in `branch-4.9` to
`4.9.1-SNAPSHOT`.
+in master to `4.10.0-alpha-0` (NOTE: we are using `alpha-0` as `SNAPSHOT`,
otherwise pypi doesn't work), and the version in
+`branch-4.9` to `4.9.1-alpha-0`.
If you are only doing a minor release, you just need to update the version in
release branch. For example, if you are doing
-4.9.1 release, you need to bump the version in `branch-4.9` to
`4.9.2-SNAPSHOT`.
+4.9.1 release, you need to bump the version in `branch-4.9` to `4.9.2-alpha-0`.
### Mark the version as released in Github
diff --git a/stream/clients/python/setup.py b/stream/clients/python/setup.py
index dbbf443..fb8a696 100644
--- a/stream/clients/python/setup.py
+++ b/stream/clients/python/setup.py
@@ -19,7 +19,7 @@ import setuptools
name = 'apache-bookkeeper-client'
description = 'Apache BookKeeper client library'
-version = '4.10.0-SNAPSHOT'
+version = '4.10.0-alpha-0'
# Should be one of:
# 'Development Status :: 3 - Alpha'
# 'Development Status :: 4 - Beta'
