This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 86bce12  Migrate command `ledgermetadata`
86bce12 is described below

commit 86bce12b58f997430f87771abb95854ee41a7248
Author: Yong Zhang <[email protected]>
AuthorDate: Wed Apr 24 18:17:04 2019 +0800

    Migrate command `ledgermetadata`
    
    Descriptions of the changes in this PR:
    
    Using `bkctl` run command `ledgermetadata`
    
    ### Motivation
    
    #2018
    
    
    Reviewers: Jia Zhai <[email protected]>, Sijie Guo <[email protected]>
    
    This closes #2019 from zymap/command-ledgermetadata
---
 .../org/apache/bookkeeper/bookie/BookieShell.java  |  47 +++----
 .../cli/commands/client/LedgerMetaDataCommand.java | 140 +++++++++++++++++++++
 .../meta/AbstractZkLedgerManagerTest.java          |   1 +
 .../bookkeeper/meta/TestLedgerMetadataSerDe.java   |   8 +-
 .../tools/cli/commands/LedgerCommandGroup.java     |   2 +
 .../commands/client/LedgerMetaDataCommandTest.java | 136 ++++++++++++++++++++
 6 files changed, 298 insertions(+), 36 deletions(-)

diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
index 02a7391..1caa1e1 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
@@ -18,14 +18,10 @@
 
 package org.apache.bookkeeper.bookie;
 
-import static 
org.apache.bookkeeper.meta.MetadataDrivers.runFunctionWithLedgerManagerFactory;
-
 import com.google.common.annotations.VisibleForTesting;
-import com.google.common.util.concurrent.UncheckedExecutionException;
 import java.io.File;
 import java.io.IOException;
 import java.io.Serializable;
-import java.nio.file.FileSystems;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
@@ -39,14 +35,11 @@ import java.util.Comparator;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Optional;
 import java.util.stream.Collectors;
 import org.apache.bookkeeper.client.LedgerEntry;
 import org.apache.bookkeeper.client.api.LedgerMetadata;
 import org.apache.bookkeeper.common.annotation.InterfaceAudience.Private;
 import org.apache.bookkeeper.conf.ServerConfiguration;
-import org.apache.bookkeeper.meta.LedgerManager;
-import org.apache.bookkeeper.meta.LedgerMetadataSerDe;
 import org.apache.bookkeeper.net.BookieSocketAddress;
 import 
org.apache.bookkeeper.tools.cli.commands.autorecovery.ListUnderReplicatedCommand;
 import 
org.apache.bookkeeper.tools.cli.commands.autorecovery.LostBookieRecoveryDelayCommand;
@@ -79,6 +72,7 @@ import 
org.apache.bookkeeper.tools.cli.commands.bookies.NukeExistingClusterComma
 import 
org.apache.bookkeeper.tools.cli.commands.bookies.NukeExistingClusterCommand.NukeExistingClusterFlags;
 import org.apache.bookkeeper.tools.cli.commands.bookies.RecoverCommand;
 import org.apache.bookkeeper.tools.cli.commands.client.DeleteLedgerCommand;
+import org.apache.bookkeeper.tools.cli.commands.client.LedgerMetaDataCommand;
 import org.apache.bookkeeper.tools.cli.commands.client.SimpleTestCommand;
 import org.apache.bookkeeper.tools.cli.commands.cookie.AdminCommand;
 import org.apache.bookkeeper.tools.cli.commands.cookie.CreateCookieCommand;
@@ -90,7 +84,6 @@ import org.apache.bookkeeper.tools.framework.CliFlags;
 import org.apache.bookkeeper.util.EntryFormatter;
 import org.apache.bookkeeper.util.LedgerIdFormatter;
 import org.apache.bookkeeper.util.Tool;
-import org.apache.bookkeeper.versioning.Versioned;
 import org.apache.commons.cli.BasicParser;
 import org.apache.commons.cli.CommandLine;
 import org.apache.commons.cli.HelpFormatter;
@@ -728,7 +721,6 @@ public class BookieShell implements Tool {
      */
     class LedgerMetadataCmd extends MyCommand {
         Options lOpts = new Options();
-        LedgerMetadataSerDe serDe = new LedgerMetadataSerDe();
 
         LedgerMetadataCmd() {
             super(CMD_LEDGERMETADATA);
@@ -739,36 +731,27 @@ public class BookieShell implements Tool {
 
         @Override
         public int runCmd(CommandLine cmdLine) throws Exception {
-            final long lid = getOptionLedgerIdValue(cmdLine, "ledgerid", -1);
-            if (lid == -1) {
+            final long ledgerId = getOptionLedgerIdValue(cmdLine, "ledgerid", 
-1);
+            if (ledgerId == -1) {
                 System.err.println("Must specify a ledger id");
                 return -1;
             }
-
-            if (cmdLine.hasOption("dumptofile") && 
cmdLine.hasOption("restorefromfile")) {
+            if (cmdLine.hasOption("dumptofile") && 
cmdLine.hasOption("restorefromefile")) {
                 System.err.println("Only one of --dumptofile and 
--restorefromfile can be specified");
                 return -2;
             }
-            runFunctionWithLedgerManagerFactory(bkConf, mFactory -> {
-                try (LedgerManager m = mFactory.newLedgerManager()) {
-                    if (cmdLine.hasOption("dumptofile")) {
-                        Versioned<LedgerMetadata> md = 
m.readLedgerMetadata(lid).join();
-                        
Files.write(FileSystems.getDefault().getPath(cmdLine.getOptionValue("dumptofile")),
-                                    serDe.serialize(md.getValue()));
-                    } else if (cmdLine.hasOption("restorefromfile")) {
-                        byte[] serialized = Files.readAllBytes(
-                                
FileSystems.getDefault().getPath(cmdLine.getOptionValue("restorefromfile")));
-                        LedgerMetadata md = serDe.parseConfig(serialized, 
Optional.empty());
-                        m.createLedgerMetadata(lid, md).join();
-                    } else {
-                        printLedgerMetadata(lid, 
m.readLedgerMetadata(lid).get().getValue(), true);
-                    }
-                } catch (Exception e) {
-                    throw new UncheckedExecutionException(e);
-                }
-                return null;
-            });
 
+            LedgerMetaDataCommand.LedgerMetadataFlag flag = new 
LedgerMetaDataCommand.LedgerMetadataFlag();
+            flag.ledgerId(ledgerId);
+            if (cmdLine.hasOption("dumptofile")) {
+                flag.dumpToFile(cmdLine.getOptionValue("dumptofile"));
+            }
+            if (cmdLine.hasOption("restorefromfile")) {
+                
flag.restoreFromFile(cmdLine.getOptionValue("restorefromfile"));
+            }
+
+            LedgerMetaDataCommand cmd = new 
LedgerMetaDataCommand(ledgerIdFormatter);
+            cmd.apply(bkConf, flag);
             return 0;
         }
 
diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/client/LedgerMetaDataCommand.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/client/LedgerMetaDataCommand.java
new file mode 100644
index 0000000..5937a24
--- /dev/null
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/client/LedgerMetaDataCommand.java
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.bookkeeper.tools.cli.commands.client;
+
+import static 
org.apache.bookkeeper.meta.MetadataDrivers.runFunctionWithLedgerManagerFactory;
+
+import com.beust.jcommander.Parameter;
+import com.google.common.util.concurrent.UncheckedExecutionException;
+import java.nio.file.FileSystems;
+import java.nio.file.Files;
+import java.util.Optional;
+import java.util.concurrent.ExecutionException;
+import lombok.Setter;
+import lombok.experimental.Accessors;
+import org.apache.bookkeeper.client.api.LedgerMetadata;
+import org.apache.bookkeeper.conf.ServerConfiguration;
+import org.apache.bookkeeper.meta.LedgerManager;
+import org.apache.bookkeeper.meta.LedgerMetadataSerDe;
+import org.apache.bookkeeper.meta.exceptions.MetadataException;
+import org.apache.bookkeeper.tools.cli.helpers.BookieCommand;
+import org.apache.bookkeeper.tools.framework.CliFlags;
+import org.apache.bookkeeper.tools.framework.CliSpec;
+import org.apache.bookkeeper.util.LedgerIdFormatter;
+import org.apache.bookkeeper.versioning.Versioned;
+
+/**
+ * Print the metadata for a ledger.
+ */
+public class LedgerMetaDataCommand extends 
BookieCommand<LedgerMetaDataCommand.LedgerMetadataFlag> {
+
+    private static final String NAME = "show";
+    private static final String DESC = "Print the metadata for a ledger, or 
optionally dump to a file.";
+    private static final String DEFAULT = "";
+    private static final long DEFAULT_ID = -1L;
+
+    private LedgerMetadataSerDe serDe = new LedgerMetadataSerDe();
+    private LedgerIdFormatter ledgerIdFormatter;
+
+    public LedgerMetaDataCommand() {
+        this(new LedgerMetadataFlag());
+    }
+
+    public LedgerMetaDataCommand(LedgerIdFormatter ledgerIdFormatter) {
+        this();
+        this.ledgerIdFormatter = ledgerIdFormatter;
+    }
+
+    public LedgerMetaDataCommand(LedgerMetadataFlag flag) {
+        super(CliSpec.<LedgerMetadataFlag>newBuilder()
+                  .withName(NAME)
+                  .withDescription(DESC)
+                  .withFlags(flag)
+                  .build());
+    }
+
+    /**
+     * Flags for ledger metadata command.
+     */
+    @Accessors(fluent = true)
+    @Setter
+    public static class LedgerMetadataFlag extends CliFlags {
+
+        @Parameter(names = { "-l", "--ledgerid" }, description = "Ledger ID", 
required = true)
+        private long ledgerId = DEFAULT_ID;
+
+        @Parameter(names = { "-d", "--dumptofile" }, description = "Dump 
metadata for ledger, to a file")
+        private String dumpToFile = DEFAULT;
+
+        @Parameter(names = { "-r", "--restorefromefile" }, description = 
"Restore metadata for ledger, from a file")
+        private String restoreFromFile = DEFAULT;
+
+        @Parameter(names =  {"-lf", "--ledgeridformatter"}, description = "Set 
ledger id formatter")
+        private String ledgerIdFormatter = DEFAULT;
+    }
+
+    @Override
+    public boolean apply(ServerConfiguration conf, LedgerMetadataFlag 
cmdFlags) {
+        if (!cmdFlags.ledgerIdFormatter.equals(DEFAULT) && ledgerIdFormatter 
== null) {
+            this.ledgerIdFormatter = 
LedgerIdFormatter.newLedgerIdFormatter(cmdFlags.ledgerIdFormatter, conf);
+        } else if (ledgerIdFormatter == null) {
+            this.ledgerIdFormatter = 
LedgerIdFormatter.newLedgerIdFormatter(conf);
+        }
+        try {
+            return handler(conf, cmdFlags);
+        } catch (Exception e) {
+            throw new UncheckedExecutionException(e.getMessage(), e);
+        }
+    }
+
+    private boolean handler(ServerConfiguration conf, LedgerMetadataFlag flag)
+        throws MetadataException, ExecutionException {
+        if (flag.ledgerId == DEFAULT_ID) {
+            System.err.println("Must specific a ledger id");
+            return false;
+        }
+        runFunctionWithLedgerManagerFactory(conf, mFactory -> {
+            try (LedgerManager m = mFactory.newLedgerManager()) {
+                if (!flag.dumpToFile.equals(DEFAULT)) {
+                    Versioned<LedgerMetadata> md = 
m.readLedgerMetadata(flag.ledgerId).join();
+                    
Files.write(FileSystems.getDefault().getPath(flag.dumpToFile),
+                                serDe.serialize(md.getValue()));
+                } else if (!flag.restoreFromFile.equals(DEFAULT)) {
+                    byte[] serialized = Files.readAllBytes(
+                        
FileSystems.getDefault().getPath(flag.restoreFromFile));
+                    LedgerMetadata md = serDe.parseConfig(serialized, 
Optional.empty());
+                    m.createLedgerMetadata(flag.ledgerId, md).join();
+                } else {
+                    printLedgerMetadata(flag.ledgerId, 
m.readLedgerMetadata(flag.ledgerId).get().getValue(), true);
+                }
+            } catch (Exception e) {
+                throw new UncheckedExecutionException(e);
+            }
+            return null;
+        });
+        return true;
+    }
+
+    private void printLedgerMetadata(long ledgerId, LedgerMetadata md, boolean 
printMeta) {
+        System.out.println("ledgerID: " + 
ledgerIdFormatter.formatLedgerId(ledgerId));
+        if (printMeta) {
+            System.out.println(md.toString());
+        }
+    }
+}
diff --git 
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/AbstractZkLedgerManagerTest.java
 
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/AbstractZkLedgerManagerTest.java
index 8e2ec0a..2c0ae4f 100644
--- 
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/AbstractZkLedgerManagerTest.java
+++ 
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/AbstractZkLedgerManagerTest.java
@@ -124,6 +124,7 @@ public class AbstractZkLedgerManagerTest extends 
MockZooKeeperTestCase {
         this.metadata = LedgerMetadataBuilder.create()
             .withDigestType(DigestType.CRC32C).withPassword(new byte[0])
             .withEnsembleSize(5)
+            .withMetadataFormatVersion(2)
             .withWriteQuorumSize(3)
             .withAckQuorumSize(3)
             .newEnsembleEntry(0L, ensemble)
diff --git 
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerMetadataSerDe.java
 
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerMetadataSerDe.java
index a0767ba..1c9de74 100644
--- 
a/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerMetadataSerDe.java
+++ 
b/bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerMetadataSerDe.java
@@ -124,7 +124,7 @@ public class TestLedgerMetadataSerDe {
     @Test
     public void testPeggedToV2SerDe() throws Exception {
         LedgerMetadataSerDe serDe = new LedgerMetadataSerDe();
-        LedgerMetadata metadata = LedgerMetadataBuilder.create()
+        LedgerMetadata metadata = 
LedgerMetadataBuilder.create().withMetadataFormatVersion(2)
             .withEnsembleSize(3).withWriteQuorumSize(2).withAckQuorumSize(1)
             
.withPassword("foobar".getBytes(UTF_8)).withDigestType(DigestType.CRC32C)
             .newEnsembleEntry(0L, Lists.newArrayList(new 
BookieSocketAddress("192.0.2.1", 3181),
@@ -163,7 +163,7 @@ public class TestLedgerMetadataSerDe {
     @Test
     public void testStoreSystemtimeAsLedgerCtimeDisabledWithVersion2()
             throws Exception {
-        LedgerMetadata lm = LedgerMetadataBuilder.create()
+        LedgerMetadata lm = 
LedgerMetadataBuilder.create().withMetadataFormatVersion(2)
             .withEnsembleSize(3).withWriteQuorumSize(2).withAckQuorumSize(1)
             
.withPassword("foobar".getBytes(UTF_8)).withDigestType(DigestType.CRC32C)
             .newEnsembleEntry(0L, Lists.newArrayList(
@@ -175,10 +175,10 @@ public class TestLedgerMetadataSerDe {
         LedgerMetadataSerDe serDe = new LedgerMetadataSerDe();
         byte[] serialized = serDe.serialize(lm);
         LedgerMetadata deserialized = serDe.parseConfig(serialized, 
Optional.of(654321L));
-        Assert.assertEquals(deserialized.getCtime(), 654321L);
+        Assert.assertEquals(654321L, deserialized.getCtime());
 
         // give it another round
         LedgerMetadata deserialized2 = 
serDe.parseConfig(serDe.serialize(deserialized), Optional.of(98765L));
-        Assert.assertEquals(deserialized2.getCtime(), 98765L);
+        Assert.assertEquals(98765L, deserialized2.getCtime());
     }
 }
diff --git 
a/tools/ledger/src/main/java/org/apache/bookkeeper/tools/cli/commands/LedgerCommandGroup.java
 
b/tools/ledger/src/main/java/org/apache/bookkeeper/tools/cli/commands/LedgerCommandGroup.java
index 86734bc..a133b5d 100644
--- 
a/tools/ledger/src/main/java/org/apache/bookkeeper/tools/cli/commands/LedgerCommandGroup.java
+++ 
b/tools/ledger/src/main/java/org/apache/bookkeeper/tools/cli/commands/LedgerCommandGroup.java
@@ -22,6 +22,7 @@ import static 
org.apache.bookkeeper.tools.common.BKCommandCategories.CATEGORY_LE
 
 import org.apache.bookkeeper.tools.cli.BKCtl;
 import org.apache.bookkeeper.tools.cli.commands.client.DeleteLedgerCommand;
+import org.apache.bookkeeper.tools.cli.commands.client.LedgerMetaDataCommand;
 import org.apache.bookkeeper.tools.cli.commands.client.SimpleTestCommand;
 import org.apache.bookkeeper.tools.common.BKFlags;
 import org.apache.bookkeeper.tools.framework.CliCommandGroup;
@@ -42,6 +43,7 @@ public class LedgerCommandGroup extends 
CliCommandGroup<BKFlags> {
         .withCategory(CATEGORY_LEDGER_SERVICE)
         .addCommand(new SimpleTestCommand())
         .addCommand(new DeleteLedgerCommand())
+        .addCommand(new LedgerMetaDataCommand())
         .build();
 
     public LedgerCommandGroup() {
diff --git 
a/tools/ledger/src/test/java/org/apache/bookkeeper/tools/cli/commands/client/LedgerMetaDataCommandTest.java
 
b/tools/ledger/src/test/java/org/apache/bookkeeper/tools/cli/commands/client/LedgerMetaDataCommandTest.java
new file mode 100644
index 0000000..d4d89c1
--- /dev/null
+++ 
b/tools/ledger/src/test/java/org/apache/bookkeeper/tools/cli/commands/client/LedgerMetaDataCommandTest.java
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.bookkeeper.tools.cli.commands.client;
+
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyLong;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.powermock.api.mockito.PowerMockito.mock;
+import static org.powermock.api.mockito.PowerMockito.when;
+import static org.powermock.api.mockito.PowerMockito.whenNew;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import org.apache.bookkeeper.client.api.LedgerMetadata;
+import org.apache.bookkeeper.conf.ServerConfiguration;
+import org.apache.bookkeeper.meta.LedgerManager;
+import org.apache.bookkeeper.meta.LedgerManagerFactory;
+import org.apache.bookkeeper.meta.LedgerMetadataSerDe;
+import org.apache.bookkeeper.meta.MetadataDrivers;
+import org.apache.bookkeeper.tools.cli.helpers.BookieCommandTestBase;
+import org.apache.bookkeeper.versioning.Version;
+import org.apache.bookkeeper.versioning.Versioned;
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.powermock.api.mockito.PowerMockito;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+/**
+ * Unit test for {@link LedgerMetaDataCommand}.
+ */
+@RunWith(PowerMockRunner.class)
+@PrepareForTest({ LedgerMetaDataCommand.class, MetadataDrivers.class, 
LedgerMetadata.class,
+    LedgerManagerFactory.class })
+public class LedgerMetaDataCommandTest extends BookieCommandTestBase {
+
+    private LedgerManager ledgerManager;
+    private LedgerManagerFactory factory;
+    private LedgerMetadataSerDe serDe;
+
+    @Mock
+    private CompletableFuture<Versioned<LedgerMetadata>> future;
+
+    private TemporaryFolder folder = new TemporaryFolder();
+
+    public LedgerMetaDataCommandTest() {
+        super(3, 0);
+    }
+
+    @Override
+    public void setup() throws Exception {
+        folder.create();
+
+        factory = mock(LedgerManagerFactory.class);
+
+        PowerMockito.mockStatic(MetadataDrivers.class);
+        PowerMockito.doAnswer(invocationOnMock -> {
+            Function<LedgerManagerFactory, ?> function = 
invocationOnMock.getArgument(1);
+            function.apply(factory);
+            return true;
+        }).when(MetadataDrivers.class, "runFunctionWithLedgerManagerFactory", 
any(ServerConfiguration.class),
+                any(Function.class));
+
+        ledgerManager = mock(LedgerManager.class);
+        when(factory.newLedgerManager()).thenReturn(ledgerManager);
+
+        LedgerMetadata ledgerMetadata = mock(LedgerMetadata.class);
+        when(ledgerMetadata.getMetadataFormatVersion()).thenReturn(1);
+        Versioned<LedgerMetadata> versioned = new 
Versioned<LedgerMetadata>(ledgerMetadata, Version.NEW);
+        versioned.setValue(ledgerMetadata);
+        when(future.join()).thenReturn(versioned);
+        when(ledgerManager.readLedgerMetadata(anyLong())).thenReturn(future);
+        when(ledgerManager.readLedgerMetadata(anyLong())).thenReturn(future);
+        when(future.get()).thenReturn(versioned);
+
+        serDe = mock(LedgerMetadataSerDe.class);
+        whenNew(LedgerMetadataSerDe.class).withNoArguments().thenReturn(serDe);
+        when(serDe.serialize(eq(ledgerMetadata))).thenReturn(new byte[0]);
+        when(serDe.parseConfig(eq(new byte[0]), 
eq(Optional.empty()))).thenReturn(ledgerMetadata);
+        when(ledgerManager.createLedgerMetadata(anyLong(), 
eq(ledgerMetadata))).thenReturn(future);
+    }
+
+    @Test
+    public void testWithDumpToFile() throws IOException {
+        File file = folder.newFile("testdump");
+        LedgerMetaDataCommand cmd = new LedgerMetaDataCommand();
+        Assert.assertTrue(cmd.apply(bkFlags, new String[] { "-l", "1", "-d", 
file.getAbsolutePath() }));
+
+        verify(ledgerManager, times(1)).readLedgerMetadata(anyLong());
+        verify(serDe, times(1)).serialize(any(LedgerMetadata.class));
+    }
+
+    @Test
+    public void testWithRestoreFromFile() throws IOException {
+        File file = folder.newFile("testrestore");
+        LedgerMetaDataCommand cmd = new LedgerMetaDataCommand();
+        Assert.assertTrue(cmd.apply(bkFlags, new String[] { "-l", "1", "-r", 
file.getAbsolutePath() }));
+
+        verify(serDe, times(1)).parseConfig(eq(new byte[0]), 
eq(Optional.empty()));
+        verify(ledgerManager, times(1)).createLedgerMetadata(anyLong(), 
any(LedgerMetadata.class));
+    }
+
+    @Test
+    public void testWithoutArgs() {
+        LedgerMetaDataCommand cmd = new LedgerMetaDataCommand();
+        Assert.assertTrue(cmd.apply(bkFlags, new String[] { "-l", "1" }));
+
+        verify(factory, times(1)).newLedgerManager();
+        verify(ledgerManager, times(1)).readLedgerMetadata(anyLong());
+    }
+
+}

Reply via email to