This is an automated email from the ASF dual-hosted git repository.

prashantkumar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 7a13905  fix gradle implicit dependency (#3029)
7a13905 is described below

commit 7a13905bc29b1b7263186c2c759b37a1c8ee6bea
Author: mauricebarnum <[email protected]>
AuthorDate: Mon Feb 14 12:19:54 2022 -0800

    fix gradle implicit dependency (#3029)
    
    ```
    > Task :bookkeeper-tools-framework:compileTestJava
    Execution optimizations have been disabled for task 
':bookkeeper-tools-framework:compileTestJava' to ensure correctness due to the 
following reasons:
      - Gradle detected a problem with the following location: 
'/Users/mbarnum/src/bookkeeper/tools/framework/build/classes/java/main'. 
Reason: Task ':bookkeeper-tools-framework:compileTestJava' uses this output of 
task ':tools:framework:compileJava' without declaring an explicit or implicit 
dependency. This can lead to incorrect results being produced, depending on 
what order the tasks are executed. Please refer to 
https://docs.gradle.org/7.3.3/userguide/validation_problems.html#implicit [...]
    ```
---
 bookkeeper-server/build.gradle | 2 +-
 settings.gradle                | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/bookkeeper-server/build.gradle b/bookkeeper-server/build.gradle
index d55aa8a..5318791 100644
--- a/bookkeeper-server/build.gradle
+++ b/bookkeeper-server/build.gradle
@@ -28,9 +28,9 @@ dependencies {
     implementation project(':bookkeeper-http:http-server')
     implementation project(':bookkeeper-proto')
     implementation project(':bookkeeper-stats')
+    implementation project(':bookkeeper-tools-framework')
     implementation project(':circe-checksum')
     implementation project(':cpu-affinity')
-    implementation project(':tools:framework')
 
     compileOnly depLibs.lombok
     compileOnly depLibs.spotbugsAnnotations
diff --git a/settings.gradle b/settings.gradle
index 0e2455a..6043b17 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -100,8 +100,7 @@ include(':bookkeeper-benchmark',
         'tests:scripts',
         'tests:shaded:bookkeeper-server-shaded-test',
         'tests:shaded:bookkeeper-server-tests-shaded-test',
-        'tests:shaded:distributedlog-core-shaded-test',
-        'tools:framework')
+        'tests:shaded:distributedlog-core-shaded-test')
 
 project(':bookkeeper-tools').projectDir = file('tools/all')
 project(':bookkeeper-tools-framework').projectDir = file('tools/framework')

Reply via email to